From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Schofield, Alison" <alison.schofield@intel.com>,
"Benjamin.Cheatham@amd.com" <Benjamin.Cheatham@amd.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"Jiang, Dave" <dave.jiang@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH v8 0/7] Add error injection support
Date: Tue, 10 Feb 2026 17:52:58 +0000 [thread overview]
Message-ID: <4b37820522cd852b321705f59e763acbe78ec799.camel@intel.com> (raw)
In-Reply-To: <20260206215008.8810-1-Benjamin.Cheatham@amd.com>
On Fri, 2026-02-06 at 15:50 -0600, Ben Cheatham wrote:
> v8 Changes:
> - Split inject-error command into 'inject-protocol-error', 'inject-media-poison' (Vishal, Alison)
> - Rename 'cxl-clear-error' command to 'cxl-clear-media-poison' (Alison)
> - Documentation rework to reflect new commands
> - Cleaned up a few error prints
> - Updated help messages
> - Change "clear" param of poison_action() to "inj" and reverse usage accordingly
> - Change cxl_memdev_has_poison_injection() to cxl_memdev_has_poison_support()
> - Used in poison_action() (cxl/inject-error.c) to report missing functionality
> more accurately
> - Print usage when '-a' option is missing for media-poison commands
> - Remove checking if '-a' option is empty in poison_action() (no longer needed)
> - Allow clearing poison when 'inject_poison' file is missing in debugfs (and vice versa)
> - Updated cover letter and commit messages
Thanks for the reworks - this looks good to me.
For the series,
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
next prev parent reply other threads:[~2026-02-10 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 21:50 [ndctl PATCH v8 0/7] Add error injection support Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 1/7] libcxl: Add debugfs path to CXL context Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 2/7] libcxl: Add CXL protocol errors Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 3/7] libcxl: Add poison injection support Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 4/7] cxl: Add inject-protocol-error command Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 5/7] cxl: Add poison injection/clear commands Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 6/7] cxl/list: Add injectable errors in output Ben Cheatham
2026-02-06 21:50 ` [PATCH v8 7/7] Documentation: Add docs for protocol and poison injection commands Ben Cheatham
2026-02-10 17:52 ` Verma, Vishal L [this message]
2026-02-13 0:12 ` [ndctl PATCH v8 0/7] Add error injection support Alison Schofield
2026-02-16 14:28 ` Cheatham, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b37820522cd852b321705f59e763acbe78ec799.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox