From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: patches@lists.linux.dev, linux-cxl@vger.kernel.org,
alison.schofield@intel.com,
Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH 2/9] dax/cxl: Fix HMEM dependencies
Date: Fri, 27 Mar 2026 09:29:27 -0700 [thread overview]
Message-ID: <4d6bdd4c-3190-48e4-a9d4-b47a71756ccd@intel.com> (raw)
In-Reply-To: <20260327052821.440749-3-dan.j.williams@intel.com>
On 3/26/26 10:28 PM, Dan Williams wrote:
> The expectation is that DEV_DAX_HMEM=y should be disallowed if any of
> CXL_ACPI, or CXL_PCI are set =m. Also DEV_DAX_CXL=y should be disallowed if
> DEV_DAX_HMEM=m. Use "$config || !$config" syntax for each dependency.
> Otherwise, the invalid DEV_DAX_HMEM=m && DEV_DAX_CXL=y configuration is
> allowed.
>
> Lastly, dax_hmem depends on the availability of the
> cxl_region_contains_resource() symbol published by the cxl_core.ko module.
> So, also prevent DEV_DAX_HMEM from being built-in when the cxl_core module
> is not built-in.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dax/Kconfig | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
> index 3683bb3f2311..504f7f735ef5 100644
> --- a/drivers/dax/Kconfig
> +++ b/drivers/dax/Kconfig
> @@ -32,6 +32,9 @@ config DEV_DAX_HMEM
> depends on EFI_SOFT_RESERVE
> select NUMA_KEEP_MEMINFO if NUMA_MEMBLKS
> default DEV_DAX
> + depends on CXL_ACPI || !CXL_ACPI
> + depends on CXL_PCI || !CXL_PCI
> + depends on CXL_BUS || !CXL_BUS
> help
> EFI 2.8 platforms, and others, may advertise 'specific purpose'
> memory. For example, a high bandwidth memory pool. The
> @@ -48,8 +51,7 @@ config DEV_DAX_CXL
> tristate "CXL DAX: direct access to CXL RAM regions"
> depends on CXL_BUS && CXL_REGION && DEV_DAX
> default CXL_REGION && DEV_DAX
> - depends on CXL_ACPI >= DEV_DAX_HMEM
> - depends on CXL_PCI >= DEV_DAX_HMEM
> + depends on DEV_DAX_HMEM || !DEV_DAX_HMEM
> help
> CXL RAM regions are either mapped by platform-firmware
> and published in the initial system-memory map as "System RAM", mapped
next prev parent reply other threads:[~2026-03-27 16:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 5:28 [PATCH 0/9] dax/hmem: Add tests for the dax_hmem takeover capability Dan Williams
2026-03-27 5:28 ` [PATCH 1/9] cxl/region: Fix use-after-free from auto assembly failure Dan Williams
2026-03-27 16:28 ` Dave Jiang
2026-03-27 19:20 ` Alison Schofield
2026-03-27 21:54 ` Dan Williams
2026-03-27 22:37 ` Alison Schofield
2026-03-27 23:43 ` Alison Schofield
2026-03-30 20:24 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 2/9] dax/cxl: Fix HMEM dependencies Dan Williams
2026-03-27 16:29 ` Dave Jiang [this message]
2026-03-27 23:44 ` Alison Schofield
2026-03-30 21:10 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 3/9] cxl/region: Limit visibility of cxl_region_contains_resource() Dan Williams
2026-03-27 16:39 ` Dave Jiang
2026-03-27 23:45 ` Alison Schofield
2026-03-30 22:19 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 4/9] cxl/region: Constify cxl_region_resource_contains() Dan Williams
2026-03-27 16:40 ` Dave Jiang
2026-03-27 23:45 ` Alison Schofield
2026-03-30 22:22 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 5/9] dax/hmem: Reduce visibility of dax_cxl coordination symbols Dan Williams
2026-03-27 16:46 ` Dave Jiang
2026-03-27 23:46 ` Alison Schofield
2026-03-30 22:26 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 6/9] dax/hmem: Fix singleton confusion between dax_hmem_work and hmem devices Dan Williams
2026-03-27 17:06 ` Dave Jiang
2026-03-27 23:46 ` Alison Schofield
2026-03-31 17:32 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 7/9] dax/hmem: Parent dax_hmem devices Dan Williams
2026-03-27 17:07 ` Dave Jiang
2026-03-27 23:47 ` Alison Schofield
2026-03-31 17:42 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 8/9] tools/testing/cxl: Simulate auto-assembly failure Dan Williams
2026-03-27 17:08 ` Dave Jiang
2026-03-27 23:48 ` Alison Schofield
2026-03-31 17:43 ` Ira Weiny
2026-03-27 5:28 ` [PATCH 9/9] tools/testing/cxl: Test dax_hmem takeover of CXL regions Dan Williams
2026-03-27 17:10 ` Dave Jiang
2026-03-27 23:58 ` Alison Schofield
2026-03-28 3:20 ` Dan Williams
2026-03-31 17:57 ` Ira Weiny
2026-03-31 18:13 ` Alison Schofield
2026-03-27 23:42 ` [PATCH 0/9] dax/hmem: Add tests for the dax_hmem takeover capability Alison Schofield
2026-03-30 21:12 ` Koralahalli Channabasappa, Smita
2026-03-30 21:17 ` Dave Jiang
2026-03-31 21:57 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d6bdd4c-3190-48e4-a9d4-b47a71756ccd@intel.com \
--to=dave.jiang@intel.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox