From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04E82C77B76 for ; Fri, 21 Apr 2023 16:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233062AbjDUQNN (ORCPT ); Fri, 21 Apr 2023 12:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233066AbjDUQNI (ORCPT ); Fri, 21 Apr 2023 12:13:08 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56AA314F75; Fri, 21 Apr 2023 09:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682093583; x=1713629583; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dDNnSFNrcC+fU68jZKfY8qcCncyrq02YdgYqi/7ZFe0=; b=SJ061jUmtq2ru/+yPqp5z2d7TCkNhdCkAxKpwLDHSYKug7wlfnVTg8fu fwGB3oq/4lvSiy4KaZNllSKxlsG6tNEX14sEN0/FXS1fOP68FI09NVUw9 tfluGjYdjbqvMJZUUsrQvcIQUHFJDExmEpGGPfFgtN7f0jJaNwAh0YwrB zdtlwVqFurMEQhWfz5o/VQwmzTwg0YTYw5d6nXvJX6OYT42CNbEtWfRIj ocfCDClhN58MulQpFRah8u6tAIimJUVppv5LEmUXVBssiSLSYQ2rqzay9 cQbO9dmubban6jD1vo3ffP7I0//PSFTGNbWrW0CvgZeGvlXSw6rp8MSmN Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10687"; a="344780653" X-IronPort-AV: E=Sophos;i="5.99,214,1677571200"; d="scan'208";a="344780653" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2023 09:13:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10687"; a="685764739" X-IronPort-AV: E=Sophos;i="5.99,214,1677571200"; d="scan'208";a="685764739" Received: from thusain-mobl1.amr.corp.intel.com (HELO [10.212.19.203]) ([10.212.19.203]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2023 09:13:00 -0700 Message-ID: <50cf5206-bcf9-a82e-55b4-bd8c780bb27e@intel.com> Date: Fri, 21 Apr 2023 09:12:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.9.0 Subject: Re: [PATCH v4 04/23] cxl: Add common helpers for cdat parsing Content-Language: en-US To: Jonathan Cameron Cc: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, dan.j.williams@intel.com, ira.weiny@intel.com, vishal.l.verma@intel.com, alison.schofield@intel.com, rafael@kernel.org, lukas@wunner.de References: <168193556660.1178687.15477509915255912089.stgit@djiang5-mobl3> <168193568543.1178687.3067575213689202382.stgit@djiang5-mobl3> <20230420104104.000065dd@Huawei.com> <71fb1962-7029-119f-f12a-32849dff659a@intel.com> <20230421170605.00000f5a@Huawei.com> From: Dave Jiang In-Reply-To: <20230421170605.00000f5a@Huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On 4/21/23 9:06 AM, Jonathan Cameron wrote: > >>>> +int cdat_table_parse_sslbis(struct cdat_header *table, >>>> + cdat_tbl_entry_handler handler, void *arg) >>> >>> Feels like these ones should take a typed arg. Sure you'll loose >>> that again to use the generic handling code, but at this level we can >>> do it I think. >> >> while DSMAS and DSLBIS takes a list_head, SSLBIS takes an xarray. I can >> create a union. > > I don't understand why, If you drop the macro usage introduced in > a later patch you can just have each one take the right thing. > That macro isn't a huge saving anyway. Oh I think I understand where you are trying to get at. Ok I'll update. > > Jonathan > >> >>> >>>> +{ >>>> + struct cdat_subtable_proc proc = { >>>> + .handler = handler, >>>> + .arg = arg, >>>> + }; >>>> + >>>> + return cdat_table_parse_entries(CDAT_TYPE_SSLBIS, table, &proc); >>>> +} >>> >> >