Re: [RFC PATCH 02/18] cxl: Move struct cxl_dev_state definition

["Cheatham, Benjamin" <benjamin.cheatham@amd.com>]

On 8/19/2025 6:33 AM, Jonathan Cameron wrote:
> On Tue, 12 Aug 2025 16:29:05 -0500
> Ben Cheatham <Benjamin.Cheatham@amd.com> wrote:
> 
>> Move struct cxl_dev_state (and associated structs) from cxlmem.h to
>> cxl.h. This is in preparation of adding a new CXL cache device type
>> that will also use cxl_dev_state.
>>
>> Signed-off-by: Ben Cheatham <Benjamin.Cheatham@amd.com>
> Hi Ben,
> 
> I'm just going to take a first (likely superficial look at this) so
> comments may well be lightweight.  I need to get my head around it
> before offering more substantial stuff.
> 
> Jonathan

No problem, thanks for taking a look!

>> ---
>>  drivers/cxl/cxl.h    | 114 +++++++++++++++++++++++++++++++++++++++++++
>>  drivers/cxl/cxlmem.h | 113 ------------------------------------------
>>  2 files changed, 114 insertions(+), 113 deletions(-)
>>
>> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
>> index 1de4fec5c8f4..751e5860423a 100644
>> --- a/drivers/cxl/cxl.h
>> +++ b/drivers/cxl/cxl.h
>> @@ -11,6 +11,7 @@
>>  #include <linux/log2.h>
>>  #include <linux/node.h>
>>  #include <linux/io.h>
>> +#include <cxl/mailbox.h>
>>  
>>  extern const struct nvdimm_security_ops *cxl_security_ops;
>>  
>> @@ -696,6 +697,119 @@ struct cxl_ep {
>>  	struct cxl_port *next;
>>  };
>>  
>> +
> One blank line probably enough.
> 

Yep, messed up the copy/paste. Will remove.

>> +/*
>> + * enum cxl_devtype - delineate type-2 from a generic type-3 device
>> + * @CXL_DEVTYPE_DEVMEM - Vendor specific CXL Type-2 device implementing HDM-D or
>> + *			 HDM-DB, no requirement that this device implements a
>> + *			 mailbox, or other memory-device-standard manageability
>> + *			 flows.
>> + * @CXL_DEVTYPE_CLASSMEM - Common class definition of a CXL Type-3 device with
>> + *			   HDM-H and class-mandatory memory device registers
>> + */
>> +enum cxl_devtype {
>> +	CXL_DEVTYPE_DEVMEM,
>> +	CXL_DEVTYPE_CLASSMEM,
>> +};
> 
>