From: Dave Jiang <dave.jiang@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
Len Brown <lenb@kernel.org>, <ira.weiny@intel.com>,
<vishal.l.verma@intel.com>, <alison.schofield@intel.com>,
<lukas@wunner.de>, <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 3/4] acpi: fix misnamed define for CDAT DSMAS
Date: Tue, 23 May 2023 07:54:49 -0700 [thread overview]
Message-ID: <5a81e0f1-4cdf-dae9-4b4d-f2a49f2a8ff5@intel.com> (raw)
In-Reply-To: <CAJZ5v0gaZK8vit53AuGEXhh5EkxOoB8xGO5vP8Gh9KC17j8mqw@mail.gmail.com>
On 5/23/23 03:46, Rafael J. Wysocki wrote:
> On Tue, May 23, 2023 at 1:24 AM Dan Williams <dan.j.williams@intel.com> wrote:
>> Dave Jiang wrote:
>>> ACPI_CEDT_DSMAS_NON_VOLATILE should be defined as
>>> ACPI_CDAT_DSMAS_NON_VOLATILE. Fix misspelled define.
>>>
>>> Cc: Rafael J. Wysocki <rafael@kernel.org>
>>> Cc: Len Brown <lenb@kernel.org>
>>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>>>
>>> ---
>>> See https://github.com/acpica/acpica/pull/874
>>> Merged
>>> ---
>>> include/acpi/actbl1.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
>>> index 81b9e794424d..15df363b9144 100644
>>> --- a/include/acpi/actbl1.h
>>> +++ b/include/acpi/actbl1.h
>>> @@ -356,7 +356,7 @@ struct acpi_cdat_dsmas {
>>>
>>> /* Flags for subtable above */
>>>
>>> -#define ACPI_CEDT_DSMAS_NON_VOLATILE (1 << 2)
>>> +#define ACPI_CDAT_DSMAS_NON_VOLATILE (1 << 2)
>> This needs to come in through an ACPICA update. If that is going to happen
>> this cycle, great, if not then I would handle it as a merge fixup after
>> the fact. I.e. just live with the misspelling to keep this patch set
>> ACPICA unencumbered, unless Rafael has different thoughts.
> You can also submit an upstream ACPICA pull request with this change
> and resend the patch with a Link tag pointing to that PR. Then we'll
> decide how to handle it.
That's been done and merged. I'll include the Link tag in the next rev.
next prev parent reply other threads:[~2023-05-23 14:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 18:32 [PATCH v2 0/4] acpi: Add CDAT parsing support to ACPI tables code Dave Jiang
2023-05-18 18:33 ` [PATCH v2 1/4] acpi: Move common tables helper functions to common lib Dave Jiang
2023-05-22 21:31 ` Dan Williams
2023-05-22 22:13 ` Dave Jiang
2023-05-22 22:25 ` Dan Williams
2023-05-23 10:38 ` Rafael J. Wysocki
2023-06-01 14:50 ` Jonathan Cameron
2023-06-01 15:38 ` Dave Jiang
2023-05-18 18:33 ` [PATCH v2 2/4] acpi: tables: Add CDAT table parsing support Dave Jiang
2023-05-22 23:12 ` Dan Williams
2023-05-23 10:43 ` Rafael J. Wysocki
2023-05-18 18:33 ` [PATCH v2 3/4] acpi: fix misnamed define for CDAT DSMAS Dave Jiang
2023-05-22 23:23 ` Dan Williams
2023-05-23 10:46 ` Rafael J. Wysocki
2023-05-23 14:54 ` Dave Jiang [this message]
2023-05-23 15:16 ` Rafael J. Wysocki
2023-05-18 18:33 ` [PATCH v2 4/4] acpi: Add defines for CDAT SSLBIS Dave Jiang
2023-05-22 23:24 ` Dan Williams
2023-05-23 10:49 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a81e0f1-4cdf-dae9-4b4d-f2a49f2a8ff5@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox