From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Fan Ni <fan.ni@samsung.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
Davidlohr Bueso <d.bueso@samsung.com>
Subject: Re: [ndctl PATCH] cxl: Fix some naming typos
Date: Tue, 1 Nov 2022 06:23:22 +0100 [thread overview]
Message-ID: <5e023420-eaee-d623-9375-ffc6594db084@amd.com> (raw)
In-Reply-To: <20221028175752.27879-1-fan.ni@samsung.com>
> The function for retrieving firmware version is named
> `cxl_memdev_get_firmware_verison`, updated to `cxl_memdev_get_firmware_version'.
>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
> ---
> Documentation/cxl/lib/libcxl.txt | 2 +-
> cxl/lib/libcxl.c | 2 +-
> cxl/lib/libcxl.sym | 2 +-
> cxl/libcxl.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/cxl/lib/libcxl.txt b/Documentation/cxl/lib/libcxl.txt
> index fd2962a..edc852d 100644
> --- a/Documentation/cxl/lib/libcxl.txt
> +++ b/Documentation/cxl/lib/libcxl.txt
> @@ -68,7 +68,7 @@ int cxl_memdev_get_major(struct cxl_memdev *memdev);
> int cxl_memdev_get_minor(struct cxl_memdev *memdev);
> unsigned long long cxl_memdev_get_pmem_size(struct cxl_memdev *memdev);
> unsigned long long cxl_memdev_get_ram_size(struct cxl_memdev *memdev);
> -const char *cxl_memdev_get_firmware_verison(struct cxl_memdev *memdev);
> +const char *cxl_memdev_get_firmware_version(struct cxl_memdev *memdev);
> size_t cxl_memdev_get_label_size(struct cxl_memdev *memdev);
> int cxl_memdev_nvdimm_bridge_active(struct cxl_memdev *memdev);
> int cxl_memdev_get_numa_node(struct cxl_memdev *memdev);
> diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c
> index e8c5d44..b7ad263 100644
> --- a/cxl/lib/libcxl.c
> +++ b/cxl/lib/libcxl.c
> @@ -1262,7 +1262,7 @@ CXL_EXPORT unsigned long long cxl_memdev_get_ram_size(struct cxl_memdev *memdev)
> return memdev->ram_size;
> }
>
> -CXL_EXPORT const char *cxl_memdev_get_firmware_verison(struct cxl_memdev *memdev)
> +CXL_EXPORT const char *cxl_memdev_get_firmware_version(struct cxl_memdev *memdev)
> {
> return memdev->firmware_version;
> }
> diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
> index 8bb91e0..febbca6 100644
> --- a/cxl/lib/libcxl.sym
> +++ b/cxl/lib/libcxl.sym
> @@ -19,7 +19,7 @@ global:
> cxl_memdev_get_ctx;
> cxl_memdev_get_pmem_size;
> cxl_memdev_get_ram_size;
> - cxl_memdev_get_firmware_verison;
> + cxl_memdev_get_firmware_version;
> cxl_cmd_get_devname;
> cxl_cmd_new_raw;
> cxl_cmd_set_input_payload;
> diff --git a/cxl/libcxl.h b/cxl/libcxl.h
> index 9fe4e99..c3c99b8 100644
> --- a/cxl/libcxl.h
> +++ b/cxl/libcxl.h
> @@ -47,7 +47,7 @@ int cxl_memdev_get_minor(struct cxl_memdev *memdev);
> struct cxl_ctx *cxl_memdev_get_ctx(struct cxl_memdev *memdev);
> unsigned long long cxl_memdev_get_pmem_size(struct cxl_memdev *memdev);
> unsigned long long cxl_memdev_get_ram_size(struct cxl_memdev *memdev);
> -const char *cxl_memdev_get_firmware_verison(struct cxl_memdev *memdev);
> +const char *cxl_memdev_get_firmware_version(struct cxl_memdev *memdev);
> size_t cxl_memdev_get_label_size(struct cxl_memdev *memdev);
> int cxl_memdev_disable_invalidate(struct cxl_memdev *memdev);
> int cxl_memdev_enable(struct cxl_memdev *memdev);
Hard to find typo with naked eyes.
Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
prev parent reply other threads:[~2022-11-01 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221028175929uscas1p1c78e5cd1b684f0b9a79302b8bc769a4f@uscas1p1.samsung.com>
2022-10-28 17:59 ` [ndctl PATCH] cxl: Fix some naming typos Fan Ni
2022-10-28 19:45 ` Verma, Vishal L
2022-10-28 20:05 ` Fan Ni
2022-11-01 5:23 ` Gupta, Pankaj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e023420-eaee-d623-9375-ffc6594db084@amd.com \
--to=pankaj.gupta@amd.com \
--cc=a.manzanares@samsung.com \
--cc=d.bueso@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=fan.ni@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox