From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
<linux-cxl@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>,
Alison Schofield <alison.schofield@intel.com>
Subject: RE: [RESEND] CXL_MEM_QUERY_COMMANDS returning commands not supported by the hardware.
Date: Fri, 21 Oct 2022 15:36:21 -0700 [thread overview]
Message-ID: <63531ee51c104_4da32949a@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20221010135925.00006e75@huawei.com>
Jonathan Cameron wrote:
>
> Resent because I can't type email addresses so this didn't got to the list..
>
> Hi All,
>
> Noticed, whilst implementing a switch CCI mailbox version of the same...
>
> UAPI documentation include/uapi/linux/cxl_mem.h says:
>
> struct cxl_mem_query_commands...
>
> Allow userspace to query the available commands supported by both the
> driver, and the hardware.
>
> Currently it seem to report all commands without checking they are in the CEL.
>
> Easy to tell given I just added a bunch of switch commands which are
> apparently supported by the type 3 devices (which would be novel).
>
> How to fix? Make the code do what the docs suggest, or change the
> docs?
>
> Or am I missing something?
No, you are not missing anything. This topic has come up before. Why
have a query if it does not reflect the state of the CEL. I would be in
favor of the enabled state in the CEL being communicated in the
CXL_MEM_QUERY_COMMANDS output payload.
prev parent reply other threads:[~2022-10-21 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 12:59 [RESEND] CXL_MEM_QUERY_COMMANDS returning commands not supported by the hardware Jonathan Cameron
2022-10-21 22:36 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63531ee51c104_4da32949a@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox