Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Adam Manzanares <a.manzanares@samsung.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: "nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
	Fan Ni <fan.ni@samsung.com>,
	"dave@stgolabs.net" <dave@stgolabs.net>,
	"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Subject: Re: [ndctl PATCH] daxctl: Skip over memory failure node status
Date: Tue, 14 Feb 2023 13:52:13 -0800	[thread overview]
Message-ID: <63ec028d9bef1_c24a529499@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230214065653.GA437651@bgt-140510-bm01>

Adam Manzanares wrote:
> On Mon, Feb 13, 2023 at 03:26:58PM -0800, Dan Williams wrote:
> > Adam Manzanares wrote:
> > > When trying to match a dax device to a memblock physical address
> > > memblock_in_dev will fail if the the phys_index sysfs file does
> > > not exist in the memblock. Currently the memory failure directory
> > > associated with a node is currently interpreted as a memblock.
> > > Skip over the memory_failure directory within the node directory.
> > 
> > Oh, interesting, I did not know memory_failure() added entries to sysfs.
> > My grep-fu is failing me though... I only found node_init_cache_dev()
> > that creates a file named "memory_side_cache" under a node. This fix
> > will work for that as well, but I am still curious where the memory
> > failure file originates.
> 
> I found the issue on next-20230119, I have a suspicion your grep-fu will
> work fine there. 

Yup, thanks. For those following along at home, it's these patches:

https://lore.kernel.org/all/20230120034622.2698268-1-jiaqiyan@google.com

...which has some implications for interoperating with CXL Scan Media
which is distinct from a hardware patrol scrubber, but that's a
discussion for a different patch set.

For this patch though:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

  reply	other threads:[~2023-02-14 21:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230213213916uscas1p2ee91a53c14ec5ddcb31322212af6cdaa@uscas1p2.samsung.com>
2023-02-13 21:39 ` [ndctl PATCH] daxctl: Skip over memory failure node status Adam Manzanares
2023-02-13 23:26   ` Dan Williams
2023-02-14  6:57     ` Adam Manzanares
2023-02-14 21:52       ` Dan Williams [this message]
2023-02-15  0:36   ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63ec028d9bef1_c24a529499@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=a.manzanares@samsung.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox