From: Ira Weiny <ira.weiny@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>, <dan.j.williams@intel.com>
Cc: <ira.weiny@intel.com>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<Jonathan.Cameron@huawei.com>, <dave@stgolabs.net>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v2] cxl/memdev: Decouple security init from devm_cxl_add_memdev()
Date: Fri, 11 Aug 2023 12:55:23 -0700 [thread overview]
Message-ID: <64d6922b4e6ed_1aed4629414@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20230811025755.15103-1-dave@stgolabs.net>
Davidlohr Bueso wrote:
> A crash was reported during type2 device enablement[0] which called
> devm_cxl_add_memdev() without an mds, causing the security state
> init steps to be bogus.
>
> BUG: kernel NULL pointer dereference, address: 0000000000000278
> [...]
> RIP: 0010:devm_cxl_add_memdev+0x1de/0x2c0 [cxl_core]
> [...]
> Call Trace:
> <TASK>
> ? __die+0x1f/0x70
> ? page_fault_oops+0x149/0x420
> ? fixup_exception+0x22/0x310
> ? kernelmode_fixup_or_oops+0x84/0x110
> ? exc_page_fault+0x6d/0x150
> ? asm_exc_page_fault+0x22/0x30
> ? devm_cxl_add_memdev+0x1de/0x2c0 [cxl_core]
> cxl_mock_mem_probe+0x632/0x870 [cxl_mock_mem]
> platform_probe+0x40/0x90
> really_probe+0x19e/0x3e0
> ? __pfx___driver_attach+0x10/0x10
> __driver_probe_device+0x78/0x160
> driver_probe_device+0x1f/0x90
> __driver_attach+0xce/0x1c0
> bus_for_each_dev+0x63/0xa0
> bus_add_driver+0x112/0x210
> driver_register+0x55/0x100
> ? __pfx_cxl_mock_mem_driver_init+0x10/0x10 [cxl_mock_mem]
> [...]
>
> Move out cxl_memdev_security_init() and allow the pci probing to call
> it directly. This is more aligned with the intention of f6b8ab32e3ec
> ("cxl/memdev: Make mailbox functionality optional").
>
> The cxl_memdev_security_shutdown() counterpart is removed altogether
> and handle the sanitation corner case directly in the unregister. In
> addition, the devm_cxl_add_memdev() cleanup path case is about ioctls,
> and regardless, there is no way for the sanitation to become active
> during that time.
>
> [0] https://lore.kernel.org/all/168592160379.1948938.12863272903570476312.stgit@dwillia2-xfh.jf.intel.com/
>
> Reported-by: Ira Weiny <ira.weiny@intel.com>
> Tested-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> Changes from v1:
> - Picked up tags.
> - Add missing EXPORT_SYMBOL_NS_GPL.
> - Kill the shutdown function.
> - Fix typo in changelog.
>
prev parent reply other threads:[~2023-08-11 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 2:57 [PATCH v2] cxl/memdev: Decouple security init from devm_cxl_add_memdev() Davidlohr Bueso
2023-08-11 19:55 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64d6922b4e6ed_1aed4629414@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox