From: Dan Williams <dan.j.williams@intel.com>
To: <alison.schofield@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<linux-cxl@vger.kernel.org>
Subject: RE: [PATCH v2] cxl/mbox: Remove useless cast in cxl_mem_create_range_info()
Date: Tue, 15 Aug 2023 18:52:32 -0700 [thread overview]
Message-ID: <64dc2be07dc3d_5ea6e2943d@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20230815172052.22514-1-alison.schofield@intel.com>
alison.schofield@ wrote:
> From: Alison Schofield <alison.schofield@intel.com>
>
> DEFINE_RES_MEM() is a wrapper around the DEFINE_RES_NAMED() macro
> which already has the (struct resource) for the compound literal.
> The user of the macro should not repeat the cast.
>
> Cleans up these sparse warnings:
> drivers/cxl/core/mbox.c:1184:18: warning: cast to non-scalar
> drivers/cxl/core/mbox.c:1184:18: warning: cast from non-scalar
>
> Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Looks good to me.
next prev parent reply other threads:[~2023-08-16 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 17:20 [PATCH v2] cxl/mbox: Remove useless cast in cxl_mem_create_range_info() alison.schofield
2023-08-16 1:52 ` Dan Williams [this message]
2023-08-17 13:04 ` Andy Shevchenko
2023-08-17 15:10 ` Davidlohr Bueso
2023-08-23 16:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64dc2be07dc3d_5ea6e2943d@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox