Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>, <linux-cxl@vger.kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
	<alison.schofield@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>
Subject: RE: [PATCH] tools/testing/cxl: slow down the mock firmware transfer
Date: Thu, 26 Oct 2023 10:23:04 -0700	[thread overview]
Message-ID: <653aa0785f533_244c8f29499@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20231026-vv-fw_upd_test_fix-v1-1-a6345df5550b@intel.com>

Vishal Verma wrote:
> The cxl-cli unit test for firmware update does operations like starting
> an asynchronous firmware update, making sure it is in progress, and
> attempting to cancel it. In some cases, such as with no or minimal
> dynamic debugging turned on, the firmware update completes too quickly,
> not allowing the test to have a chance to verify it was in progress.
> This caused a failure of the signature:
> 
>   expected fw_update_in_progress:true
>   test/cxl-update-firmware.sh: failed at line 88
> 
> Fix this by adding a fixed delay (2ms) to each firmware transfer
> request handled by the mocked interface.
> 
> Reported-by: Dan Williams <dan.j.williams@intel.com>

Tested-by: Dan Williams <dan.j.williams@intel.com>

Thanks, Vishal!

      reply	other threads:[~2023-10-26 17:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26 17:20 [PATCH] tools/testing/cxl: slow down the mock firmware transfer Vishal Verma
2023-10-26 17:23 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653aa0785f533_244c8f29499@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox