Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>
Cc: <linux-cxl@vger.kernel.org>, Jim Harris <jim.harris@samsung.com>,
	"Dan Williams" <dan.j.williams@intel.com>, <dave@stgolabs.net>,
	<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
	<ira.weiny@intel.com>
Subject: Re: [PATCH v3 2/2] cxl: Add decoders_committed sysfs attribute to cxl_port
Date: Fri, 27 Oct 2023 20:39:01 -0700	[thread overview]
Message-ID: <653c825587190_244c8f2944c@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20231019153843.00007850@Huawei.com>

Jonathan Cameron wrote:
> On Mon, 16 Oct 2023 10:57:54 -0700
> Dave Jiang <dave.jiang@intel.com> wrote:
> 
> > This attribute allows cxl-cli to determine whether there are decoders
> > committed to a memdev.  This is only a snapshot of the state, and
> > doesn't offer any protection or serialization against a concurrent
> > disable-region operation.
> > 
> > Reviewed-by: Jim Harris <jim.harris@samsung.com>
> > Suggested-by: Dan Williams <dan.j.williams@intel.com>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Seems reasonable, but it is adding ABI so the docs are missing.
> Documentation/ABI/testing/sysfs-bus-cxl

Agreed, folded in the following:

diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
index 087f762ebfd5..432610f41aee 100644
--- a/Documentation/ABI/testing/sysfs-bus-cxl
+++ b/Documentation/ABI/testing/sysfs-bus-cxl
@@ -178,6 +178,21 @@ Description:
                hardware decoder target list.
 
 
+What:          /sys/bus/cxl/devices/portX/decoders_committed
+Date:          October, 2023
+KernelVersion: v6.7
+Contact:       linux-cxl@vger.kernel.org
+Description:
+               (RO) A memory device is considered active when any of its
+               decoders are in the "committed" state (See CXL 3.0 8.2.4.19.7
+               CXL HDM Decoder n Control Register). Hotplug and destructive
+               operations like "sanitize" are blocked while device is actively
+               decoding a Host Physical Address range. Note that this number
+               may be elevated without any regionX objects active or even
+               enumerated, as this may be due to decoders established by
+               platform firwmare or a previous kernel (kexec).
+
+
 What:          /sys/bus/cxl/devices/decoderX.Y
 Date:          June, 2021
 KernelVersion: v5.14

  reply	other threads:[~2023-10-28  3:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20231016175800uscas1p2cdf5532581e564f356b36c0126d2a25f@uscas1p2.samsung.com>
2023-10-16 17:57 ` [PATCH v3 1/2] cxl: Add cxl_decoders_committed() helper Dave Jiang
2023-10-16 17:57   ` [PATCH v3 2/2] cxl: Add decoders_committed sysfs attribute to cxl_port Dave Jiang
2023-10-19 14:38     ` Jonathan Cameron
2023-10-28  3:39       ` Dan Williams [this message]
2023-10-16 19:46   ` [PATCH v3 1/2] cxl: Add cxl_decoders_committed() helper Jim Harris
2023-10-19 14:34   ` Jonathan Cameron
2023-10-23 17:49   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653c825587190_244c8f2944c@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jim.harris@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox