Re: [PATCH v3] cxl: Add cxl_num_decoders_committed() usage to cxl_test

[Dan Williams <dan.j.williams@intel.com>]

Alison Schofield wrote:
> On Mon, Nov 06, 2023 at 10:26:45AM -0700, Dave Jiang wrote:
> > Commit 458ba8189cb4 ("cxl: Add cxl_decoders_committed() helper") missed the
> > conversion for cxl_test. Add usage of cxl_num_decoders_committed() to
> > replace the open coding.
> > 
> > Suggested-by: Alison Schofield <alison.schofield@intel.com>
> 
> Search for more usages of commit_end in cxl.c that may use new helper. 

Did you have one in mind? Of these:

tools/testing/cxl/test/cxl.c:672:	if (port->commit_end + 1 != id) {
tools/testing/cxl/test/cxl.c:675:			dev_name(&cxld->dev), port->id, port->commit_end + 1);
tools/testing/cxl/test/cxl.c:679:	port->commit_end++;
tools/testing/cxl/test/cxl.c:694:	if (port->commit_end != id) {
tools/testing/cxl/test/cxl.c:697:			dev_name(&cxld->dev), port->id, port->commit_end);
tools/testing/cxl/test/cxl.c:701:	port->commit_end--;
tools/testing/cxl/test/cxl.c:793:	port->commit_end = cxld->id;
tools/testing/cxl/test/cxl.c:825:		iter->commit_end = 0;

Only tools/testing/cxl/test/cxl.c:694 looks interesting, but given
cxl_decoder_reset() does not use cxl_num_decoders_committed(), neither
should mock_decoder_reset().