Re: [PATCH] cxl: Fix unregister_region() callback parameter assignment

[Ira Weiny <ira.weiny@intel.com>]

Dave Jiang wrote:
> In devm_cxl_add_region(), devm_add_action_or_reset() is called by passing
> in unregister_region() with data ptr of 'cxlr'. However, in
> unregister_region(), the passed in parameter is incorrectly assumed to be
> a 'struct device' rather than the 'cxlr' pointer. The code has been
> working because 'struct device' is the first member of 'struct
> cxl_region'. Issue found by inspection. Fix the assignment so that cxlr is
> pointing directly to the passed in parameter.
> 
> Fixes: 23a22cd1c98b ("cxl/region: Allocate HPA capacity to regions")

Technically I think the essence of the bug existed in 

Fixes: 779dd20cfb56 ("cxl/region: Add region creation support") 

...because the region pointer was used as a device there too.

Other than that:

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/region.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

[snip]