From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F2B619754D for ; Thu, 5 Sep 2024 11:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725534523; cv=none; b=UPfv9Jv3VNdQOXkJISeDmFSiqk9CrVnqqepds4bzgRXk7VZma/OWN3dfWjuzwkoLsT59nq/RWS9H7IoqTvz/NwMqfD7fbbTQf6LudDGrAcv5UrtsLliwx/R28ISXZz9aYfDdduxSvRpT0iVLdHVRwCZ6Domphd9cCMw0QannCAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725534523; c=relaxed/simple; bh=T74FLgEMRbwNanNVn34x8nN09A+oCVO9WxT1A0X8lsg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dSfkj4J6K4+ZMtGXy34UVkuYfz43TOl6zuy+uU2NGZWpGV46Pziox9nKznOfSF/CbL14pWyUOyEG7VdGwZMbeWPrwhmqFkogvjEwA7jkITQizkE9Iv8q+FUQQ4QWcCYZ1/Aa6mxktHcPYZzdeSkf/kmLoU0ayZMoDU4KfoJqG6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f0sXFzh2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f0sXFzh2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725534520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GuM9XXecG6m7Bq9F8M7Qo2NTP71Qi/wqsXre7rS8OKY=; b=f0sXFzh2mSR+90bMjbtK9mOzFylnK+v+g8wv70FETy3PjbnyRRma8hGq1P3yQRTDhmJxdr 9iowib27UUSb8gw7gZlgmyjpfQSZl+mSYPgS3qmmkKIqlsg+LKTkLOnpcRwuugHzY7S4d6 BJ26CyrZ2eHVDHB4HY/h6z2WhyEI208= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-222-_OX_XTFqNeWn1AwXg8gW1w-1; Thu, 05 Sep 2024 07:08:39 -0400 X-MC-Unique: _OX_XTFqNeWn1AwXg8gW1w-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42c7936e564so5818085e9.2 for ; Thu, 05 Sep 2024 04:08:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725534518; x=1726139318; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GuM9XXecG6m7Bq9F8M7Qo2NTP71Qi/wqsXre7rS8OKY=; b=AWqW5LFnbKsVX6MEgL83bvaA080Z64E+ooqnUcnWxednd5R1L1p1WeghV1rt8iWIwf vKiCmCzOziKRHRwDEtdOsPgvoyycdnPCPXe7kc+J8eKd48iC8lYYxY0QiJkMYG+gHZfn pxqLpk3K1+p1MZgIcWyGDlF7Q9w/p3hXO6PO8vY5X0rf60ttwWhBJBIsDCIed9bi2YJK e+MZHEjLLo5WDyzSbLgVJnXDcW29VHSp2E+bvIpT/+/WzV1ru0I2+RwRmp/NDWcH3l4q fQeGnocilc0GTDDYPVCLucG9ny8D699HMoWxe2woFeDyFi2bnF5T8Myg1niP9lIAWTRA lkiw== X-Forwarded-Encrypted: i=1; AJvYcCWqeX06llGE8lPSd+HNI/NyufLVkQCY7bjqy/RF6sdz2fTXW9I9O2/+RdbhYcnkhqOCvhSi1UC5HOc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxts1HEmFuPCkEec1Ec7YcnbvSfOmSFXNbmaUiRZVPLAIjBaxjJ qDmosxdV0NFvOJQuSVteHa2y35CJzrBP+hZGTfHibBX17tyyd7Xq3dYdCfSFUQxpbfkNKFc02aZ JoTeYwkDEY4WuqAsHA1YZRnVoVS/08m8bebs8Etkj81VZuhMe1ukB89aJMQ== X-Received: by 2002:a05:600c:474f:b0:428:d83:eb6b with SMTP id 5b1f17b1804b1-42c880efd7emr85389885e9.15.1725534518064; Thu, 05 Sep 2024 04:08:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8jb7VG0GmOLyhAxFm/EVuV0ysPY7NXFeWFToQ9W8b34/g4Fr0+wanY40DaGxyVG126b9kvg== X-Received: by 2002:a05:600c:474f:b0:428:d83:eb6b with SMTP id 5b1f17b1804b1-42c880efd7emr85389645e9.15.1725534517477; Thu, 05 Sep 2024 04:08:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:5400:6c12:d0e2:3757:2963? (p200300cbc70854006c12d0e237572963.dip0.t-ipconnect.de. [2003:cb:c708:5400:6c12:d0e2:3757:2963]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6e33d55sm234023595e9.41.2024.09.05.04.08.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 04:08:36 -0700 (PDT) Message-ID: <65838cc0-9a20-4994-a0ef-9cd50bb00951@redhat.com> Date: Thu, 5 Sep 2024 13:08:35 +0200 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory To: Andy Shevchenko , Dan Williams Cc: "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.09.24 12:56, Andy Shevchenko wrote: > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: >> Huang, Ying wrote: >>> Andy Shevchenko writes: > > [..] > >>>> You may move Cc list after '---', so it won't unnecessarily pollute the commit >>>> message. >>> >>> Emm... It appears that it's a common practice to include "Cc" in the >>> commit log. >> >> Yes, just ignore this feedback, it goes against common practice. Cc list >> as is looks sane to me. > > It seems nobody can give technical arguments why it's better than just keeping > them outside of the commit message. Mantra "common practice" nowadays is > questionable. Just look at how patches look like in the git tree that Andrew picks up. (IIRC, he adds a bunch of CCs himself that are not even part of the original patch). Having in the git tree who was actually involved/CCed can be quite valuable. More helpful than get_maintainers.pl sometimes. -- Cheers, David / dhildenb