Re: [PATCH v11 3/4] cxl/core, EINJ: Add EINJ CXL debugfs files and EINJ helper functions

[Dan Williams <dan.j.williams@intel.com>]

Ben Cheatham wrote:
[..]
> >> Wait, no y == 2 and m == 1, so:
> >>
> >> depends on ACPI_APEI_EINJ >= CXL_BUS
> >>
> >> ...is correct, but you need IS_ENABLED(CONFIG_CXL_EINJ), not
> >> IS_REACHABLE to guard those exports.
> > 
> > Ok, I'll test it out today and let you know if it works.
> > 
> 
> Alright, I tested it yesterday and that fix doesn't work. When I
> change the guard to IS_ENABLED(CONFIG_CXL_EINJ) and set
> CONFIG_CXL_EINJ=n and CONFIG_ACPI_APEI_EINJ=y/m I get a redefinition
> error in einj.c. I've found a 4 ways to fix this so far, here they
> are:
> 
[..]
> 4. Change the Kconfig definition of CXL_EINJ to depends on ACPI_APEI_EINJ = CXL_BUS.
> 
> My vote is for option 4, but I figured I should ask to see if you (or
> anyone else reading this thread) likes a different one or has a better
> idea than the ones I laid out.

Looks good to me, it is the easiest to understand. Everything else looks
like a Kbuild unit test that only a build-bot would love. EINJ needs to
remain modular for the non-CXL case and if someone decides they want to
turn on this debug feature then CXL needs to be modular too.