From: Ira Weiny <ira.weiny@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, <alison.schofield@intel.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
<linux-cxl@vger.kernel.org>
Subject: Re: [PATCH] cxl/trace: Initialize cxl_poison region name to NULL
Date: Thu, 14 Mar 2024 10:24:05 -0700 [thread overview]
Message-ID: <65f332b556705_13f3a294b0@iweiny-mobl.notmuch> (raw)
In-Reply-To: <65f3016b8b0d9_1fe3d329441@iweiny-mobl.notmuch>
Ira Weiny wrote:
> alison.schofield@ wrote:
> > From: Alison Schofield <alison.schofield@intel.com>
> > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
[snip]
> > index bdf117a33744..bc5ca4d530d1 100644
> > --- a/drivers/cxl/core/trace.h
> > +++ b/drivers/cxl/core/trace.h
> > @@ -657,7 +657,7 @@ TRACE_EVENT(cxl_poison,
> > __string(host, dev_name(cxlmd->dev.parent))
> > __field(u64, serial)
> > __field(u8, trace_type)
> > - __string(region, region)
> > + __string(region, NULL)
>
> Couldn't this be "" instead of NULL then remove the __assign_str() if
> region is NULL?
>
> Ira
>
> > __field(u64, overflow_ts)
> > __field(u64, hpa)
> > __field(u64, dpa)
> >
> > base-commit: e8f897f4afef0031fe618a8e94127a0934896aba
> > --
> > 2.37.3
> >
>
> k
Apologies... This is just a lost 'k' looking for it's home. (emacs users
don't hate on me please... :-)
Ira
prev parent reply other threads:[~2024-03-14 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 4:43 [PATCH] cxl/trace: Initialize cxl_poison region name to NULL alison.schofield
2024-03-14 13:53 ` Ira Weiny
2024-03-14 17:04 ` Alison Schofield
2024-03-14 17:25 ` Ira Weiny
2024-03-14 18:44 ` Steven Rostedt
2024-03-14 18:47 ` Steven Rostedt
2024-03-14 20:08 ` Alison Schofield
2024-03-14 20:34 ` Steven Rostedt
2024-03-14 20:49 ` Ira Weiny
2024-03-14 17:24 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f332b556705_13f3a294b0@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox