Re: [PATCH v2] tools/testing/cxl: Remove cxl_test module math loading message

[Dave Jiang <dave.jiang@intel.com>]

On 1/25/23 11:13 AM, alison.schofield@intel.com wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> Commit "tools/testing/cxl: Add XOR Math support to cxl_test" added
> a module parameter to cxl_test for the interleave_arithmetic option.
> In doing so, it also added this dev_dbg() message describing which
> option cxl_test used during load:
> "[  111.743246] (NULL device *): cxl_test loading modulo math option"
> 
> That "(NULL device *)" has raised needless user concern and the info
> emitted can be discovered elsewhere.
> 
> Remove the dev_dbg() messages and make the module_param readable via
> sysfs in case a lookup is wanted.

Should the module_param perm change go to a second patch since it has 
nothing to do with removal of the debug warning?

> 
> Fixes: Fixes: 7a7e6edfca85 ("tools/testing/cxl: Add XOR Math support to cxl_test")
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> ---
> 
> Changes in v2:
> - Use correct Fixes Tag in commit log. (Ira)
> - Param always appears in sysfs. Don't say otherwise in commit log. (Ira)
> - Commit msg: s/modulo/module, s/messages/message
> - No change in code
> 
>   tools/testing/cxl/test/cxl.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 30ee680d38ff..ede84de69f59 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1135,11 +1135,9 @@ static __init int cxl_test_init(void)
>   	if (interleave_arithmetic == 1) {
>   		cfmws_start = CFMWS_XOR_ARRAY_START;
>   		cfmws_end = CFMWS_XOR_ARRAY_END;
> -		dev_dbg(NULL, "cxl_test loading xor math option\n");
>   	} else {
>   		cfmws_start = CFMWS_MOD_ARRAY_START;
>   		cfmws_end = CFMWS_MOD_ARRAY_END;
> -		dev_dbg(NULL, "cxl_test loading modulo math option\n");
>   	}
>   
>   	rc = populate_cedt();
> @@ -1326,7 +1324,7 @@ static __exit void cxl_test_exit(void)
>   	unregister_cxl_mock_ops(&cxl_mock_ops);
>   }
>   
> -module_param(interleave_arithmetic, int, 0000);
> +module_param(interleave_arithmetic, int, 0444);
>   MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
>   module_init(cxl_test_init);
>   module_exit(cxl_test_exit);
> 
> base-commit: 589c3357370a596ef7c99c00baca8ac799fce531