Re: [PATCH v4] cxl/events: Use a common struct for DRAM and General Media events

[Ira Weiny <ira.weiny@intel.com>]

Fabio M. De Francesco wrote:

[snip]

>  
> -/*
> - * General Media or DRAM Event Common Fields
> - * - provides common access to phys_addr
> - */
> -struct cxl_event_common {
> -	struct cxl_event_record_hdr hdr;
> -	__le64 phys_addr;
> -} __packed;
> -
>  union cxl_event {
>  	struct cxl_event_generic generic;
>  	struct cxl_event_gen_media gen_media;
>  	struct cxl_event_dram dram;
>  	struct cxl_event_mem_module mem_module;
> -	struct cxl_event_common common;
> +	/* dram & gen_media event header */

I like the comment here.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

[snip]