From: Ira Weiny <ira.weiny@intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
Jane Chu <jane.chu@oracle.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <nvdimm@lists.linux.dev>,
<linux-cxl@vger.kernel.org>
Cc: Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [PATCH] dax: delete a stale directory pmem
Date: Fri, 18 Oct 2024 15:50:20 -0500 [thread overview]
Message-ID: <6712ca0c1447d_44de62943b@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20241017101144.1654085-1-harshit.m.mogalapalli@oracle.com>
Harshit Mogalapalli wrote:
> After commit: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") the pmem/
> directory is not needed anymore and Makefile changes were made
> accordingly in this commit, but there is a Makefile and pmem.c in pmem/
> which are now stale and pmem.c is empty, remove them.
>
> Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT")
> Suggested-by: Vegard Nossum <vegard.nossum@oracle.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Marked for nvdimm-next
Thanks!
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/dax/pmem/Makefile | 7 -------
> drivers/dax/pmem/pmem.c | 10 ----------
> 2 files changed, 17 deletions(-)
> delete mode 100644 drivers/dax/pmem/Makefile
> delete mode 100644 drivers/dax/pmem/pmem.c
>
> diff --git a/drivers/dax/pmem/Makefile b/drivers/dax/pmem/Makefile
> deleted file mode 100644
> index 191c31f0d4f0..000000000000
> --- a/drivers/dax/pmem/Makefile
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0-only
> -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem.o
> -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem_core.o
> -
> -dax_pmem-y := pmem.o
> -dax_pmem_core-y := core.o
> -dax_pmem_compat-y := compat.o
> diff --git a/drivers/dax/pmem/pmem.c b/drivers/dax/pmem/pmem.c
> deleted file mode 100644
> index dfe91a2990fe..000000000000
> --- a/drivers/dax/pmem/pmem.c
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -/* Copyright(c) 2016 - 2018 Intel Corporation. All rights reserved. */
> -#include <linux/percpu-refcount.h>
> -#include <linux/memremap.h>
> -#include <linux/module.h>
> -#include <linux/pfn_t.h>
> -#include <linux/nd.h>
> -#include "../bus.h"
> -
> -
> --
> 2.46.0
>
>
prev parent reply other threads:[~2024-10-18 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 10:11 [PATCH] dax: delete a stale directory pmem Harshit Mogalapalli
2024-10-17 17:19 ` Dan Williams
2024-10-18 20:50 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6712ca0c1447d_44de62943b@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jane.chu@oracle.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vegard.nossum@oracle.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox