From: Dan Williams <dan.j.williams@intel.com>
To: Alison Schofield <alison.schofield@intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Davidlohr Bueso <dave@stgolabs.net>,
"Gregory Price" <gourry@gourry.net>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Alejandro Lucero <alucerop@amd.com>,
Ben Cheatham <benjamin.cheatham@amd.com>
Subject: Re: [PATCH] cxl: Rename ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3
Date: Thu, 7 Nov 2024 13:35:13 -0800 [thread overview]
Message-ID: <672d329119d63_10bb7294cc@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <Zy0kt2i9C6eirhPN@aschofie-mobl2.lan>
Alison Schofield wrote:
[..]
> > I think so too. However, I prefer to keep this patch just mechanic
> > renaming and do these changes in another patch. Do you agree?
> >
>
> I don't know. I was just questioning where and how far the naming scheme
> needs to change.
>
> Maybe Jonathan, as the Suggested-by, can chime in and move this ahead.
I feel like we are going to be living with the ghosts of the original
"Type2 / Type3" naming problem for the rest of the subsystem's lifespan
especially since they were encoded in the ABI and ABI is forever.
I am not opposed to this localized rename in drivers/cxl/acpi.c on
principal, but in terms of incremental value relative to the thrash, it's
questionable.
For example changes to include/acpi/actbl1.h need to be chased through
ACPICA, at which point is this rename really worth it?
next prev parent reply other threads:[~2024-11-07 21:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 8:41 [PATCH] cxl: Rename ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3 Huang Ying
2024-11-05 15:17 ` Ira Weiny
2024-11-05 22:25 ` Fan Ni
2024-11-06 2:27 ` Alison Schofield
2024-11-06 2:43 ` Huang, Ying
2024-11-07 20:36 ` Alison Schofield
2024-11-07 21:35 ` Dan Williams [this message]
2024-11-10 6:13 ` Huang, Ying
2024-11-12 2:37 ` Zhang, Rui
2024-12-10 20:08 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672d329119d63_10bb7294cc@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=alucerop@amd.com \
--cc=benjamin.cheatham@amd.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox