From: Dan Williams <dan.j.williams@intel.com>
To: "Ye, Huaisheng" <huaisheng.ye@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"jim.harris@samsung.com" <jim.harris@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jia, Pei P" <pei.p.jia@intel.com>,
"Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: RE: [PATCH] [RFC] cxl/region: Fix region creation for greater than x2 switches
Date: Mon, 9 Dec 2024 16:08:06 -0800 [thread overview]
Message-ID: <67578666a401b_10a083294d7@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <SA3PR11MB74613BB0D280113C7DD65DB69F592@SA3PR11MB7461.namprd11.prod.outlook.com>
Ye, Huaisheng wrote:
[..]
> > > Now, "ancestral_ways" also does not show up in the CXL
> > > specification, but that is because the CXL specification leaves at
> > > as an exercise for software to figure out an algorithm to validate
> > > that a proposed ordering of memory-device-decoders in a region can
> > > be supported by the given CXL topology.
>
> Regarding this patch, the distance (or offset) is obtained by
> multiplying the number of distinct targets in region's interest and
> its all ancestral nr_targets. If we renamed "distance" to
> "ancestral_ways", I am afraid that confusion will arise in the future.
> Because this variable is not only determined by ancestral ways.
>
> I think ep_distance or ep_interval, even ep_offset would be better.
The name of the variable is never going to be fully self-describing.
Lets just use the term "distance" and supplement with a healthy comment.
Sent a v2 with that fixup.
prev parent reply other threads:[~2024-12-10 0:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-27 7:57 [PATCH] [RFC] cxl/region: Fix region creation for greater than x2 switches Huaisheng Ye
2024-10-31 9:33 ` Zhijian Li (Fujitsu)
2024-11-06 9:34 ` Ye, Huaisheng
2024-11-07 1:11 ` Dan Williams
2024-11-07 15:23 ` Dave Jiang
2024-11-12 1:56 ` Ye, Huaisheng
2024-12-10 0:08 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67578666a401b_10a083294d7@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=huaisheng.ye@intel.com \
--cc=jim.harris@samsung.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
--cc=pei.p.jia@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox