From: Dan Williams <dan.j.williams@intel.com>
To: Chenyuan Yang <chenyuan0y@gmail.com>, <dave@stgolabs.net>,
<jonathan.cameron@huawei.com>, <dave.jiang@intel.com>,
<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
<ira.weiny@intel.com>, <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Chenyuan Yang <chenyuan0y@gmail.com>
Subject: Re: [PATCH] cxl/acpi: Add Null check for adev
Date: Thu, 13 Mar 2025 15:31:04 -0700 [thread overview]
Message-ID: <67d35ca81debc_11987294cf@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20250313190753.450546-1-chenyuan0y@gmail.com>
Chenyuan Yang wrote:
> Not all devices have an ACPI companion fwnode, so adev might be NULL.
> This is similar to the commit cd2fd6eab480 ("platform/x86: int3472:
> Check for adev == NULL").
No, please do not consume review bandwidth with patches like this.
Read the full commit you referenced it explicitly states the failing
condition:
"This can e.g. (theoretically) happen when a user manually binds one of
the int3472 drivers to another i2c/platform device through sysfs."
Then think through whether that theoretical condition applies to the
cxl_acpi driver and the ACPI0017 device.
prev parent reply other threads:[~2025-03-13 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 19:07 [PATCH] cxl/acpi: Add Null check for adev Chenyuan Yang
2025-03-13 22:04 ` Alison Schofield
2025-03-13 22:27 ` Dave Jiang
2025-03-13 22:31 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d35ca81debc_11987294cf@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=chenyuan0y@gmail.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox