From: Dan Williams <dan.j.williams@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
<nvdimm@lists.linux.dev>
Cc: <alison.schofield@intel.com>
Subject: Re: [NDCTL PATCH v5 3/3] cxl/test: Add test for cxl features device
Date: Tue, 22 Apr 2025 22:37:23 -0700 [thread overview]
Message-ID: <68087c931a8d3_71fe2941d@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <6808612be8ffa_71fe29469@dwillia2-xfh.jf.intel.com.notmuch>
Dan Williams wrote:
[..]
> This does not look like typical meson conditional functionality. I would
> expect is to match what happens for conditional "keyutils"
> functionality. A new "if get_option('fwctl').enabled()" option that
> gates other dependencies.
Recall that the include/uapi/linux/ndctl.h dependency is vendored in
ndctl/ndctl.h. Keep the same policy for all uapi dependencies. I.e. do
not make the ndctl need to reacy to whatever random version of a uapi
header exists ships in the build environment. Just vendor latest kernel
headers like include/uapi/cxl/features.h in the project directly.
Make the option to enable fwctl support for a meson option.
next prev parent reply other threads:[~2025-04-23 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 18:47 [NDCTL PATCH v5 0/3] ndctl: Add support and test for CXL Features support Dave Jiang
2025-04-11 18:47 ` [NDCTL PATCH v5 1/3] cxl: Add cxl_bus_get_by_provider() Dave Jiang
2025-04-11 18:47 ` [NDCTL PATCH v5 2/3] cxl: Enumerate major/minor of FWCTL char device Dave Jiang
2025-04-11 20:53 ` Alison Schofield
2025-04-11 21:06 ` Dave Jiang
2025-04-23 3:31 ` Dan Williams
2025-04-11 18:47 ` [NDCTL PATCH v5 3/3] cxl/test: Add test for cxl features device Dave Jiang
2025-04-23 3:40 ` Dan Williams
2025-04-23 5:37 ` Dan Williams [this message]
2025-04-15 20:19 ` [NDCTL PATCH v5 0/3] ndctl: Add support and test for CXL Features support Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68087c931a8d3_71fe2941d@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox