From: <dan.j.williams@intel.com>
To: <marc.herbert@linux.intel.com>, <linux-cxl@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <alison.schofield@intel.com>,
<dan.j.williams@intel.com>
Cc: Marc Herbert <marc.herbert@linux.intel.com>
Subject: Re: [ndctl PATCH v3 1/2] test: move err() function at the top
Date: Fri, 11 Jul 2025 16:56:55 -0700 [thread overview]
Message-ID: <6871a4c78ae41_1d3d10030@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20250611235256.3866724-2-marc.herbert@linux.intel.com>
marc.herbert@ wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
>
> move err() function at the top so we can fail early. err() does not have
> any dependency so it can be first.
>
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
> ---
> test/common | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
Looks ok to me
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2025-07-11 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 23:44 [ndctl PATCH v3] test: fail on unexpected kernel error & warning, not just "Call Trace" marc.herbert
2025-06-11 23:44 ` [ndctl PATCH v3 1/2] test: move err() function at the top marc.herbert
2025-07-11 23:56 ` dan.j.williams [this message]
2025-06-11 23:44 ` [ndctl PATCH v3 2/2] test: fail on unexpected kernel error & warning, not just "Call Trace" marc.herbert
2025-07-12 0:32 ` dan.j.williams
2025-07-19 0:22 ` Marc Herbert
2025-06-12 0:02 ` [ndctl PATCH v3] " Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6871a4c78ae41_1d3d10030@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=marc.herbert@linux.intel.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox