From: <dan.j.williams@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>
Cc: <peterz@infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-cxl@vger.kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
Dave Jiang <dave.jiang@intel.com>,
David Lechner <dlechner@baylibre.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH v2] cleanup: Fix "unused function" warnings with conditional guards
Date: Wed, 17 Sep 2025 16:21:07 -0700 [thread overview]
Message-ID: <68cb426324810_10520100fa@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <20250917160644.6f85ca40b1e352fa117dabf9@linux-foundation.org>
Andrew Morton wrote:
[..]
> > Alternatively just merge the suggestion in [1], and call it a day.
> >
> > Link: http://lore.kernel.org/20250813152142.GP4067720@noisy.programming.kicks-ass.net [1]
>
> lgtm, unless we think this (your) patch improves the code for other reasons?
The tl;dr above is that the warning could have small value, but probably
not greater than the overall benefit to Linux to stop bothering folks
with this low-value warning by default at W=1.
So I am over the sunk costs, and moving this warning to W=2 is the way
to go.
next prev parent reply other threads:[~2025-09-17 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 22:50 [PATCH v2] cleanup: Fix "unused function" warnings with conditional guards Dan Williams
2025-09-17 23:06 ` Andrew Morton
2025-09-17 23:21 ` dan.j.williams [this message]
2025-09-18 19:21 ` Andy Shevchenko
2025-09-18 19:26 ` dan.j.williams
2025-09-22 6:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68cb426324810_10520100fa@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=dave.jiang@intel.com \
--cc=dlechner@baylibre.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox