From: Ira Weiny <ira.weiny@intel.com>
To: Michal Clapinski <mclapinski@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>, <nvdimm@lists.linux.dev>,
<linux-cxl@vger.kernel.org>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
<linux-kernel@vger.kernel.org>,
Michal Clapinski <mclapinski@google.com>
Subject: Re: [PATCH v3 5/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the dax device driver
Date: Tue, 18 Nov 2025 15:48:28 -0600 [thread overview]
Message-ID: <691ce9acae44c_7a9a10020@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20251024210518.2126504-6-mclapinski@google.com>
Michal Clapinski wrote:
> Signed-off-by: Michal Clapinski <mclapinski@google.com>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Sorry for the delay. I picked up this series but I find that this breaks
the device-dax and daxctl-create.sh.
I was able to fix device-dax with a sleep, see below.
I'm not 100% sure what to do about this.
I don't want to sprinkle sleeps around the tests. daxctl-create.sh also
randomly fail due to the races introduced. So not sure exactly where to
sprinkle them without more work.
Could dropping just this patch and landing the others achieve most of what
you need?
Ira
diff --git a/test/device-dax.c b/test/device-dax.c
index 49c9bc8b1748..817c76b0a88b 100644
--- a/test/device-dax.c
+++ b/test/device-dax.c
@@ -246,6 +246,7 @@ static int __test_device_dax(unsigned long align, int loglevel,
goto out;
}
+sleep(1);
sprintf(path, "/dev/%s", daxctl_dev_get_devname(dev));
fd = open(path, O_RDONLY);
if (fd < 0) {
next prev parent reply other threads:[~2025-11-18 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 21:05 [PATCH v3 0/5] dax: add PROBE_PREFER_ASYNCHRONOUS to all the dax drivers Michal Clapinski
2025-10-24 21:05 ` [PATCH v3 1/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the pmem driver Michal Clapinski
2025-10-24 21:05 ` [PATCH v3 2/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the kmem driver Michal Clapinski
2025-10-24 21:05 ` [PATCH v3 3/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the cxl driver Michal Clapinski
2025-10-24 21:05 ` [PATCH v3 4/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the hmem drivers Michal Clapinski
2025-10-24 21:05 ` [PATCH v3 5/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the dax device driver Michal Clapinski
2025-11-18 21:48 ` Ira Weiny [this message]
2025-11-20 17:11 ` Michał Cłapiński
2025-11-21 0:48 ` Ira Weiny
2025-10-24 23:05 ` [PATCH v3 0/5] dax: add PROBE_PREFER_ASYNCHRONOUS to all the dax drivers dan.j.williams
2025-10-27 15:52 ` Dave Jiang
2025-11-14 12:24 ` Michał Cłapiński
2025-11-21 0:58 ` dan.j.williams
2025-11-21 16:33 ` Michał Cłapiński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=691ce9acae44c_7a9a10020@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mclapinski@google.com \
--cc=nvdimm@lists.linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox