From: <dan.j.williams@intel.com>
To: Gregory Price <gourry@gourry.net>, <dan.j.williams@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
"Dave Jiang" <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 1/2] cxl/region: Timeout auto region assembly waiting for endpoints
Date: Fri, 30 Jan 2026 14:46:20 -0800 [thread overview]
Message-ID: <697d34bca8bc8_1d6f1009f@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <aX0AfDapYz6-xRYX@gourry-fedora-PF4VCD3F>
Gregory Price wrote:
> On Fri, Jan 30, 2026 at 10:26:06AM -0800, dan.j.williams@intel.com wrote:
> > I do not see how we get into this situation. If dax_kmem comes up, then
> > there is nothing to clean up. Yes, these can race, but typical locking
> > should ensure full forward progress or cleanup.
>
> yes as long as the watchdog checks for the region actually having come
> up or not before unbinding, it should be ok - but then it seems a little
> odd to push that to userland if the driver basically already has all
> that knowledge.
A couple observations:
1/ cxl-cli already knows that raw region unbind is problematic, hence
the doom and gloom documentation around the --force option.
2/ The driver does not know the error recovery policy for region
assembly. The mechanism being enabled is that, in the case of CXL
assembly failing due to potential platform quirks, there is a chance
that the default DAX fallback could recover operation.
If the fallback is always broken because of the insert_resource() in the
construct_region() path, then that constrained problem needs to be fixed
first. Once that mechanism is fixed the rest of this becomes a pure
policy problem and I argue is suitable for userspace to handle. The
incomplete region is the kernel telling the admin the unvarnished truth
about what it knows to about the CXL topology. Same as an incomplete
RAID array.
prev parent reply other threads:[~2026-01-30 22:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 4:23 [PATCH 1/2] cxl/region: Timeout auto region assembly waiting for endpoints Alison Schofield
2026-01-30 4:23 ` [PATCH 2/2] cxl/region: Unregister auto-created region when assembly fails Alison Schofield
2026-01-30 17:45 ` dan.j.williams
2026-01-31 1:04 ` Alison Schofield
2026-01-31 15:49 ` Gregory Price
2026-02-05 0:32 ` Alison Schofield
2026-02-05 4:22 ` Gregory Price
2026-02-03 3:07 ` dan.j.williams
2026-02-05 0:20 ` Alison Schofield
2026-02-05 1:03 ` dan.j.williams
2026-01-30 4:58 ` [PATCH 1/2] cxl/region: Timeout auto region assembly waiting for endpoints dan.j.williams
2026-01-30 17:42 ` Gregory Price
2026-01-30 18:26 ` dan.j.williams
2026-01-30 19:03 ` Gregory Price
2026-01-30 22:46 ` dan.j.williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=697d34bca8bc8_1d6f1009f@dwillia2-mobl4.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gourry@gourry.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox