From: "Dan Williams (nvidia)" <djbw@kernel.org>
To: "Bowman, Terry" <terry.bowman@amd.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
Smita Koralahalli <smita.koralahallichannabasappa@amd.com>,
Robert Richter <rrichter@amd.com>,
Jonathan Cameron <jic23@kernel.org>,
"Dan Williams (nvidia)" <djbw@kernel.org>,
Shiju Jose <shiju.jose@huawei.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
Ben Cheatham <Benjamin.Cheatham@amd.com>,
Lukas Wunner <lukas@wunner.de>,
"PradeepVineshReddy.Kodamati@amd.com"
<PradeepVineshReddy.Kodamati@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: RFC: CXL: How to handle trace event ABI break from CXL_HEADERLOG_SIZE fix?
Date: Wed, 20 May 2026 15:18:56 -0700 [thread overview]
Message-ID: <6a0e33507e961_1717cc100f6@djbw-dev.notmuch> (raw)
In-Reply-To: <51a77746-5199-44a2-aa2e-d04cdd6084e7@amd.com>
Bowman, Terry wrote:
> Hi Mauro and Everyone,
>
> During development of the CXL protocol series [1], the Sashiko tool
> identified an issue in the CXL RAS UCE trace logging for Ports and Endpoints.
> Specifically, the CXL RAS UCE header log size is incorrectly defined in
> drivers/cxl/cxl.h.
>
> The UCE header log size is currently defined as 128 u32s (512 bytes),
> whereas it should be 16 u32s (64 bytes) per CXL r4.0 8.2.4.17.7. Correcting
> this will change the trace format and break the existing ABI contract
> with rasdaemon.
>
> How would you recommend proceeding to resolve this?
Split the definitions into one that reads from the register space and
once that passes the parsed log to the trace buffer.
Something like:
u32 hl[CXL_HEADERLOG_TRACE_SIZE_U32];
...zero-fill that and put a comment about how userspace has already
grown a dependency on the buggy size.
In other words, keep the userspace compatibility, but fix the iomem
overflow.
next prev parent reply other threads:[~2026-05-20 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 19:55 RFC: CXL: How to handle trace event ABI break from CXL_HEADERLOG_SIZE fix? Bowman, Terry
2026-05-20 22:18 ` Dan Williams (nvidia) [this message]
2026-05-21 12:23 ` Bowman, Terry
2026-05-21 19:51 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a0e33507e961_1717cc100f6@djbw-dev.notmuch \
--to=djbw@kernel.org \
--cc=Benjamin.Cheatham@amd.com \
--cc=PradeepVineshReddy.Kodamati@amd.com \
--cc=dave.jiang@intel.com \
--cc=jic23@kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mchehab@kernel.org \
--cc=rrichter@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shiju.jose@huawei.com \
--cc=smita.koralahallichannabasappa@amd.com \
--cc=terry.bowman@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox