From: Donet Tom <donettom@linux.ibm.com>
To: Jeff Moyer <jmoyer@redhat.com>,
Donet Tom <donettom@linux.vnet.ibm.com>,
Alison Schofield <alison.schofield@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
Ritesh Harjani <ritesh.list@gmail.com>
Subject: Re: [PATCH] [ndctl PATCH v2] ndctl/list: display region caps for any of BTT, PFN, DAX
Date: Wed, 26 Feb 2025 11:32:30 +0530 [thread overview]
Message-ID: <6f43cf6e-a3b7-4746-be15-d354cc6dd699@linux.ibm.com> (raw)
In-Reply-To: <x49y0y0oi1g.fsf@segfault.usersys.redhat.com>
On 2/20/25 19:05, Jeff Moyer wrote:
>> diff --git a/ndctl/json.c b/ndctl/json.c
>> index 23bad7f..7646882 100644
>> --- a/ndctl/json.c
>> +++ b/ndctl/json.c
>> @@ -381,7 +381,7 @@ struct json_object *util_region_capabilities_to_json(struct ndctl_region *region
>> struct ndctl_pfn *pfn = ndctl_region_get_pfn_seed(region);
>> struct ndctl_dax *dax = ndctl_region_get_dax_seed(region);
>>
>> - if (!btt || !pfn || !dax)
>> + if (!btt && !pfn && !dax)
>> return NULL;
>>
>> jcaps = json_object_new_array();
> Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
>
Thanks Jeff
Hi Alison
Should I send a v3 with Reviewed-by tag or will you take the patch with
the tag?
Thanks
Donet
>
next prev parent reply other threads:[~2025-02-26 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 6:20 [PATCH] [ndctl PATCH v2] ndctl/list: display region caps for any of BTT, PFN, DAX Donet Tom
2025-02-20 13:35 ` Jeff Moyer
2025-02-26 6:02 ` Donet Tom [this message]
2025-02-26 7:00 ` Zhijian Li (Fujitsu)
2025-02-27 6:13 ` Donet Tom
2025-02-26 19:43 ` Alison Schofield
2025-02-27 6:14 ` Donet Tom
2025-02-26 7:01 ` Zhijian Li (Fujitsu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f43cf6e-a3b7-4746-be15-d354cc6dd699@linux.ibm.com \
--to=donettom@linux.ibm.com \
--cc=alison.schofield@intel.com \
--cc=donettom@linux.vnet.ibm.com \
--cc=jmoyer@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox