From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3161EC875B for ; Thu, 7 Sep 2023 21:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237607AbjIGVmL (ORCPT ); Thu, 7 Sep 2023 17:42:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232519AbjIGVmL (ORCPT ); Thu, 7 Sep 2023 17:42:11 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8479B1BD2; Thu, 7 Sep 2023 14:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694122927; x=1725658927; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yGPK4K1omlCXEBqIdMg908APtr7Mny4+WAToGCu8DlE=; b=jc4wmrdJyVVZhKkb00lrLBvopX3sXK4urSs3kdOEwr32QL9o5kBR+cgZ Z/MhPk26Y1bqPCIC9T1FapF0iIjjLIZ3aq2yOX/pZeJQIY4r26snSRFHx MSnSsPO/o2OC4BJv2haB8onwi2arNOp5B496N3ic+KByqLvo7fHKkI63/ RLf0oZcdffBWNK4RSjYziBmM0cPJaOijc7ktObMhdgPu9WCSo8kmd4MWZ XG91Yqrl64kM8YQSQxdvyNCak1DMf9HnWFhzimX8pWWeEfFvSOB+lt6ya gV/dmEg0AeYGwuwQrl5M9DFHnS7DiEsVOHiFNYonuL24uMR9Wo7Jo9ODv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="357796906" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="357796906" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 14:42:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10826"; a="718875722" X-IronPort-AV: E=Sophos;i="6.02,236,1688454000"; d="scan'208";a="718875722" Received: from ningle-mobl2.amr.corp.intel.com (HELO [10.209.13.77]) ([10.209.13.77]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2023 14:42:06 -0700 Message-ID: <735d3933-72ea-bbe6-be3b-767b3e44d837@intel.com> Date: Thu, 7 Sep 2023 14:42:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v4 2/2] ACPI: NUMA: Apply SRAT proximity domain to entire CFMWS window Content-Language: en-US To: alison.schofield@intel.com, "Rafael J. Wysocki" , Len Brown , Dan Williams , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Jonathan Cameron , Dave Jiang , Mike Rapoport Cc: x86@kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Derick Marks References: From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On 7/10/23 13:02, alison.schofield@intel.com wrote: > + /* > + * The SRAT may have already described NUMA details for all, > + * or a portion of, this CFMWS HPA range. Extend the memblks > + * found for any portion of the window to cover the entire > + * window. > + */ > + if (!numa_fill_memblks(start, end)) > return 0; FWIW, the pieces didn't really fit together for me for this pair of patches until I read *this* comment. Either way: Acked-by: Dave Hansen