From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E931FFC7C; Mon, 7 Apr 2025 14:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.244.66 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744036506; cv=fail; b=pVMVVlxZUJ1h0YsQue2DHioSchfnxQChPnWDRuv4jVtMheSEPchCI7SL9t2gpu95J9pCmcWCWGYVM5XG9JEMYJ7MnnC45Gsdm/php1Wh8wGUyWKQ2h/V5Aw36giekGI3ct7VTD4gAEG2AtFnprr63RIjbf9OTamjOmg8gJ0+qW8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744036506; c=relaxed/simple; bh=9pyEKdPYax5jh9dFRBRFyOX459TceG1c73TZkI5sLqQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=ibUReA5XVeGec/UJewq94DFPeZi5TUaz85BWROWW3pQtfBKosctZ73L8wL9CLSWO+Tq1TE2hn11RFTyksRCvDATEklstEl0MaLHaGd37lgRMnQz9y6UmV3a/L3Bpau4OKvHmlnOIOe4c+6MNxReWfGfcVFJ2VRpC3csa8OjZZtE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=yMKKcP63; arc=fail smtp.client-ip=40.107.244.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="yMKKcP63" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G4CwsAFXYwjZ0Qy+n5WvcuRNdWX4qZQcx540QHpjQO/UWlEagzCQEQ5zm3s80Xi0XiEe4EbexjP4UAZpmj6q4gMLAXYdDGktM+J2GriXSpDSV/P8ysjOkTDjN3yhZgxmKa9TP3RZ8oub7DaBz26lNFQDL1c93v5FSP/55m6R3LKknH5nZqfB/njdvp7fFCtrExvvF+JC7ZDtKeyKG5APHhXzkLi70XVctjyHv1EpaAqYul2PF3+a0vxgLtpwhgy1qO+rRoCoTwFa26sdrGtkjtJkrR2KEXZdqczy+xCoqDjC5djWVds+EpSpetMBuVPO90xmnPq/FhpGsOVCpvZxmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9pyEKdPYax5jh9dFRBRFyOX459TceG1c73TZkI5sLqQ=; b=JhPs5r1tXEDFtzSxeaudxhsKLRS6f074Ehj417pSWvOYaMrh3cU+SrRTIYP5l8di1thDdmsIhavwBhLGc8X2bK2JQbzzIOzFBrRuaDQfEBs6al5O64+cQnDwmGvPQA/M8oTdbYzdSYHmj/6kQynahkEJAYNBgc6tLqd2/yAf1JwEqE5sdTLnGIUMgZS94JHTWoE4LUNc0aA6r4Yx4qaOhBesCoe8sqFuFztOV8w62/NTBKhvvVcPHADrsE/d5DCIw2dF1oiJcP8Jaj2dj3XOyQmHq8spgyVVKu0W6Py1FD0NM7dg7u++XHKXCMonq5Wt6f/oJue//0ejX6eY5rJHyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9pyEKdPYax5jh9dFRBRFyOX459TceG1c73TZkI5sLqQ=; b=yMKKcP63gIS5Yk4CIn50vDAWPk5gDXTpmqdqW7Bt14TSozMrEADtFXsUtToN8XGHZDDGSvRrIeUvw76E3z/7iZkNC6iisW+/hcCAenAbDDvRfY+McN/NZ00WY1Pemq0NHtmjygRzvTcbzqr50Ufw6vwJ+DYeMiBGhNajj76p7FY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DS0PR12MB6390.namprd12.prod.outlook.com (2603:10b6:8:ce::7) by PH8PR12MB6963.namprd12.prod.outlook.com (2603:10b6:510:1be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 14:35:02 +0000 Received: from DS0PR12MB6390.namprd12.prod.outlook.com ([fe80::38ec:7496:1a35:599f]) by DS0PR12MB6390.namprd12.prod.outlook.com ([fe80::38ec:7496:1a35:599f%5]) with mapi id 15.20.8606.033; Mon, 7 Apr 2025 14:35:01 +0000 Message-ID: <75f23255-afde-4241-be7b-a12620814d2c@amd.com> Date: Mon, 7 Apr 2025 09:34:57 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 15/16] CXL/PCI: Enable CXL protocol errors during CXL Port probe To: Jonathan Cameron Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, nifan.cxl@gmail.com, dave@stgolabs.net, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, dan.j.williams@intel.com, bhelgaas@google.com, mahesh@linux.ibm.com, ira.weiny@intel.com, oohall@gmail.com, Benjamin.Cheatham@amd.com, rrichter@amd.com, nathan.fontenot@amd.com, Smita.KoralahalliChannabasappa@amd.com, lukas@wunner.de, ming.li@zohomail.com, PradeepVineshReddy.Kodamati@amd.com References: <20250327014717.2988633-1-terry.bowman@amd.com> <20250327014717.2988633-16-terry.bowman@amd.com> <20250404180537.000074fd@huawei.com> Content-Language: en-US From: "Bowman, Terry" In-Reply-To: <20250404180537.000074fd@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9PR13CA0140.namprd13.prod.outlook.com (2603:10b6:806:27::25) To DS0PR12MB6390.namprd12.prod.outlook.com (2603:10b6:8:ce::7) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB6390:EE_|PH8PR12MB6963:EE_ X-MS-Office365-Filtering-Correlation-Id: 68a368e0-ca79-4077-f9af-08dd75e160e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UGRIVW93cDl0NGZXUyt4c3VwVGo1ZFFnSVFaODNKZDhXMzVkVXN6VzJkOTZh?= =?utf-8?B?Y256Umg0cWdpN1E0SDRjV25aQ0V0SXo5VzlFbEFiNDlHYUJEc2YwaVgrM0FO?= =?utf-8?B?YU5vemlBQ2VkSjhvS1k3MXozZ1pmeUdoa3RXZmViT0orajVDQnFHUERnLzhv?= =?utf-8?B?ZmsxWE5aUENCZnZwMjhkVTJKWHExbktJckdTWWlWM0FHb3ZJakd4SlJIWjho?= =?utf-8?B?aytrZk5vVmNlMGZEVzhwL0ZsTHhBVTZSWHQwcWdVM0JiN0NrTHliTC9Ibm8x?= =?utf-8?B?VU40ZjMrVFl5SENLalZsVzA0TVQvdW43b3NxVU5yN21MMW5xMkhqdjUxUkkx?= =?utf-8?B?NGZOLzBvcy90bEVxTm9zTjV0aVdPeGpyL1ZtL280SWlFVFQvdWp2c0xBNGtw?= =?utf-8?B?MG82L09yZUdka0RYcGExOWh1TGI2TXRoT1pScU11amp1WUMzcjBObzVNVnZw?= =?utf-8?B?OHAyaW53YTZaKzZJc1AzN2tubDhWdUhJNWdueFdzWTR6cCsyelQ5TWduYThy?= =?utf-8?B?dENsNU9ybXpDckVpNkFrZmZtRlpQT0tzWFVqai9lRUdjbGRUa0JEYzFvcTlG?= =?utf-8?B?RU9sYUhYQ3RXemlyMzNBaWRTdExDOVlzMndENDdXRzNOTS9ncE1VdGc5NFhM?= =?utf-8?B?WU5qdHhqaEExVTZXTThrU2hhRFQ5dFZzdzRWRzR0WDhOWW9aN09ReXVNeE55?= =?utf-8?B?dkptZmFEcGpmaEJyMWlnRjFkbjZIN1IvV3BONnRGeFlaTC9vMTZYb2FvdFhm?= =?utf-8?B?VlhkeG9YaFpJWTJtL3N2T0x1TWFkSURtbHNqVjlZM2hjOGQ0QURFaC8yRkpS?= =?utf-8?B?MXBmM2hEa0JBZGlRbUF2TmFLWGhpWmNGT2lZTXJKWDhDbEw5WEVPaU9HUCtO?= =?utf-8?B?cE82RWRMdGJEdHY2WXB4V0NNdjlWMFQ1cS81SEVBKzNycVlzWkhtZlJqZ1pD?= =?utf-8?B?RjViY0lDaS9tY01nakltT3FadFpLSkR2U3FCL1pMOHJmTmlMNzg1Y1NMaVRv?= =?utf-8?B?a2k1YlplVnQrUjBxVUozTDBJTFFuc3ROSjcxS0dFaVlwVmNHdmgyYkZNbE5m?= =?utf-8?B?OUZuRkQ5YW5mSUpuTE02ZndkNGoyRHAzaER4WDdNOXVXbWttZE4xU2JIaU1y?= =?utf-8?B?ZDN0bzg3d3gvYmJrdi9oYUVHY0ZHMGhqb0U5SzlnWUM5MXZwMTVrNDZHejcx?= =?utf-8?B?S28wRkdoeXBMUXAzdW1SOE5RU1EyeUZJT2p6Z3U1dmtSOFBzUVVXK2s4QnMw?= =?utf-8?B?WkpDemgzdWVnZEd2MEhJTUorekhGWEFrOFFnNkI2ZUVXbEJZcVJIZjdYZzBs?= =?utf-8?B?bGkwaVVUREtOUnlRSVdXOGt2WG9EOGJTWDgvMHR5NUszaE1UcFBWTm9xcURV?= =?utf-8?B?cm02dnlPS0NHSkFURUFiSis4eStIcGFKR0U5R05Nb3h2WDJaOVFBb3BkUEhj?= =?utf-8?B?YlA1N2xscTNCOWlpUXVQMEkvRHJXSFVUVXVGUmFWcnd1UzdNQU9TZDduZFZx?= =?utf-8?B?alNISlozbWJvZno3bHNoUGxXS240cFVsbXBxSG5lZ04yaE5vZ0IySW5GZG5D?= =?utf-8?B?VU8zWm9JSW1XTWdkbzREWmtxd0kzUCtCemkydDZ3eExKN3pDWk03b2RMa3pV?= =?utf-8?B?WWhYUm1XR0J0bUFWUXJEWEhzZks3SUR4K0V2TnVwU3NSMkdKTjRFRVVVODYv?= =?utf-8?B?UGRwWTg0YjRpcHlmR0p3N0dUckNrdngzT2RQb2gwRDNyRkYycFRLZUd2QkUv?= =?utf-8?B?RHhmOU1TalVyZ2UzOWpxR1dERGtJK1pPWVUvV0VYQkk2ZE1JUGxlZVZoZWRp?= =?utf-8?B?a2xzSU94RTZIcmt3bDVsSGIvWkg1TVBKQU5iTitaa1VOZFpZSW1TaWdheks4?= =?utf-8?Q?IuMxiGDSXmtPY?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB6390.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXR2U3AzY0wrTDF6QWZtZGl6U2xoWXpwSndBSVV6M2h0OWFGaXhrSmFxL0Rv?= =?utf-8?B?cnZ3UysyMkhmNm1zWGRQZWpBM0xLZnZ3ai9ZYXc2NzEwcjZWSnY3ZXJoTjVG?= =?utf-8?B?ODRrV0gzU1dTdDY2U3JZQVFaTW0raHRlM2ZGQVhaTHBMeDhmeUt2U0xyQU9N?= =?utf-8?B?M1pQWlBsY3gycmJta25RTFJwZTlqZWxVTnBhVElRY1lRUE15dHRadi9uQWlY?= =?utf-8?B?NFBQYW9xcUExc0lVdWlZbm5oZWgyeTdUVEtoSVhwMnphUmpwWm9DVmJHVytw?= =?utf-8?B?d1BKOWV4c3VET25MK25TbUg3Q2ZPeTlJUzU5M1J4SjVXYURrNElJMWJ2RC9l?= =?utf-8?B?ZURvN1paU0x4eGdYTTRXU0pkVmNFbzRxamNFNmdmRFRDRlp6aGJuRkwzOGNZ?= =?utf-8?B?Y0hjVlBBWUxtcytiWkx4OWdacTB5d3J3b2lkeXl2SXRRYndINStuVjY4Ymhn?= =?utf-8?B?Ty9JbEZlWVZpNm9OOGZDbmZmbXRFV0JXMi9sR1YrbWczNEdRVXl6K25neFVF?= =?utf-8?B?aDJlR0ZEVzRIKzZsbXJ6RHN5dXU4TXZDMEsyWEl0NThpdzI4dmRRQW51VDVw?= =?utf-8?B?WjBUVlZWVXI3QnJPQ2Nic0NjOTlBTFUxYTFzQzB1ajhnSGJGVHdUelJEak9h?= =?utf-8?B?QVlPb3RxUTRvTjh6ZnlpUHUzZmYwVThLQ0ZOOUVwUjNrUWVZS0lEYmEwZHVL?= =?utf-8?B?ckV0bXZEcjRZZTQ0UTcyaDhnS3d1NnJUa3M2dFJ6bWdVOWlETFV4SUxneEQw?= =?utf-8?B?VXpBdHljUktFNUlTN0ZwelJFUG01ZXBUcDVKRUxwUlBzMjQ1Y21lNjdOSnRo?= =?utf-8?B?YkZHTmt1U0RBT0tCN2hTN0lDQ0JWTElOSVdTbW9VbWYzdzYzMlowNDYwUjA5?= =?utf-8?B?TVZqVEw5QUc3Z3kwTEJReFRiNlhXMFQvY0RaV3RsbHFnOTlTeThVRThhamJp?= =?utf-8?B?a1g2TDc5NGpKM2tjcWVscEZvYktGTTRROE02UmhjRC9kVWI2elRUTzA1eVFR?= =?utf-8?B?NWdJalN4WmczeU50TE5Zc3Y3WitRcVdlNlNuWHliWVY2RW1ML2Qrb0dySXRx?= =?utf-8?B?QnkrZTcwdkRHN2VZa1U0VkFtUTVmWk9YTHA3MFdPSzVwMVRST1BuZjhHb1FB?= =?utf-8?B?ZVFSaGR3TGx2ckt4aUx2ZHFtN20weGJRV1grUnJUNHd5ZnZCOWpOcW14aG1J?= =?utf-8?B?cXBLWVY0R3p6OTl0U2pRTnlCVXZGNklxeEhUSTBCc0VBZVdhOUx0enJLTUNx?= =?utf-8?B?U20vWUFxaTFvYWFtYk1YSlQ4eEJHTXp1MGJSQnRTVFNGREtJQ01YRzZxSGVC?= =?utf-8?B?SmdTTU9idW14anFtTTBIaEN5OXUxUmJsL3RzbmNVZGdPc0RCY3ErWjhXS0J5?= =?utf-8?B?M3IwS1BESkxNbWNlZGI3blJHWUNKeWZDZXFKeElKaHZURUhrNjNENVhUN0Fz?= =?utf-8?B?R1laS0pzWCtxajd5MWRvalJheDNwaVlFaTFZTzgzSFhuaEVFSThmcEVGa1ln?= =?utf-8?B?dSs3QUFJYXFHbzVRL0o3LzNTN0cyUmJQell0amk3NGlKMTIzQTlYclJINk10?= =?utf-8?B?S0QyZWVKWVdZMDRXZm5ZT0tyZE5CaVFOTnEyM1o2VGVkTFltSWNiOERlZTdZ?= =?utf-8?B?VGRtYW0zbXNlTXNzeDRDT3MrN0FONnJrZUVwMmFMZEYvQVhmREw5QW9Lbk8y?= =?utf-8?B?VktxWjN3NzVrd2w4NllwcXdYbUpLSXRPRUVqL252VXhmeXl5eEdQME1rRHNQ?= =?utf-8?B?TEhCT3crUzh4UUFaYlR5UTFDVXB6SlJzR1p2dyttWTViOTRJN0MvVDJjc2hn?= =?utf-8?B?NmxUVVNpclNoR0hVOSt2dXlGNk45T0N4T2V3eHIrdkNic1o1MGVXdi9CTnBC?= =?utf-8?B?N0J3SFNEelNWZDh2VzlvS0wvQmRpTlF3UU5xbkVWeURRV3YxUjZiM3MrcGNN?= =?utf-8?B?Yzh0Q3dwamNLZ29ZMUFPbWxicG96RTBTSDRiaTZ5dWhybTJnczRzYTNDVjRa?= =?utf-8?B?b1IxUUxLeWVpUUFpbjB2b1NSQ1prbFF2Ky94dVNGbjFjY2xiNFdOYVNWK3hI?= =?utf-8?B?Qjc5VG1hMXVrTkxHSHFzbXlOczBmOEpvYXlCNDE3TVA0SHhDZDZLQWoxUVdn?= =?utf-8?Q?AxHIgTpTfAggE3fOcr4jka3WJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68a368e0-ca79-4077-f9af-08dd75e160e1 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 14:35:01.2513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kKf0O6E2FbaxYOTI79/7rzILAoFH0oGaf4jYs9z37hu6IQb2QhfMS6y39uHy1z0bLW5BusMuahq7m6yp+wgqJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6963 On 4/4/2025 12:05 PM, Jonathan Cameron wrote: > On Wed, 26 Mar 2025 20:47:16 -0500 > Terry Bowman wrote: > >> CXL protocol errors are not enabled for all CXL devices at boot. These >> must be enabled inorder to process CXL protocol errors. >> >> Export the AER service driver's pci_aer_unmask_internal_errors(). >> >> Introduce cxl_enable_port_errors() to call pci_aer_unmask_internal_errors(). >> pci_aer_unmask_internal_errors() expects the pdev->aer_cap is initialized. >> But, dev->aer_cap is not initialized for CXL Upstream Switch Ports and CXL >> Downstream Switch Ports. Initialize the dev->aer_cap if necessary. Enable AER >> correctable internal errors and uncorrectable internal errors for all CXL >> devices. >> >> Signed-off-by: Terry Bowman > Reviewed-by: Jonathan Cameron Thanks for reviewing. Terry