Re: [PATCH v3 05/10] fwctl: FWCTL_RPC to execute a Remote Procedure Call to device firmware

Jason Gunthorpe
2024-08-22T00:14:39Z

On Wed, Aug 21, 2024 at 04:49:50PM -0700, Jakub Kicinski wrote:
> On Wed, 21 Aug 2024 15:10:57 -0300 Jason Gunthorpe wrote:
> > + case FWCTL_RPC_DEBUG_WRITE_FULL:
> > + if (!capable(CAP_SYS_RAWIO))
> > + return -EPERM;
> > + fallthrough;
> > + case FWCTL_RPC_DEBUG_WRITE:
>
> Nacked-by: Jakub Kicinski <kuba@kernel.org> # RFC 3514

Your "evil bit" thing has been responded to already and that isn't how
it works.

> How many times do I have to ask you to keep my tags, and to CC netdev?

It is on patch 6 which is where I said I'd put it:

https://lore.kernel.org/all/20240605120634.GS19897@nvidia.com/

You never asked me for netdev ccs.

Jason