* [PATCH] cxl/hdm: Use str_plural() to simplify the code
@ 2025-08-11 12:25 Xichao Zhao
2025-08-11 15:49 ` Dave Jiang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xichao Zhao @ 2025-08-11 12:25 UTC (permalink / raw)
To: dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel, Xichao Zhao
Use the string choice helper function str_plural() to simplify the code.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/cxl/core/hdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
index e9e1d555cec6..37176c0a781f 100644
--- a/drivers/cxl/core/hdm.c
+++ b/drivers/cxl/core/hdm.c
@@ -197,7 +197,7 @@ struct cxl_hdm *devm_cxl_setup_hdm(struct cxl_port *port,
*/
if (should_emulate_decoders(info)) {
dev_dbg(dev, "Fallback map %d range register%s\n", info->ranges,
- info->ranges > 1 ? "s" : "");
+ str_plural(info->ranges));
cxlhdm->decoder_count = info->ranges;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/hdm: Use str_plural() to simplify the code
2025-08-11 12:25 [PATCH] cxl/hdm: Use str_plural() to simplify the code Xichao Zhao
@ 2025-08-11 15:49 ` Dave Jiang
2025-08-12 0:14 ` Alison Schofield
2025-08-13 0:01 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2025-08-11 15:49 UTC (permalink / raw)
To: Xichao Zhao, dave, jonathan.cameron, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel
On 8/11/25 5:25 AM, Xichao Zhao wrote:
> Use the string choice helper function str_plural() to simplify the code.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/core/hdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index e9e1d555cec6..37176c0a781f 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -197,7 +197,7 @@ struct cxl_hdm *devm_cxl_setup_hdm(struct cxl_port *port,
> */
> if (should_emulate_decoders(info)) {
> dev_dbg(dev, "Fallback map %d range register%s\n", info->ranges,
> - info->ranges > 1 ? "s" : "");
> + str_plural(info->ranges));
> cxlhdm->decoder_count = info->ranges;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/hdm: Use str_plural() to simplify the code
2025-08-11 12:25 [PATCH] cxl/hdm: Use str_plural() to simplify the code Xichao Zhao
2025-08-11 15:49 ` Dave Jiang
@ 2025-08-12 0:14 ` Alison Schofield
2025-08-13 0:01 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Alison Schofield @ 2025-08-12 0:14 UTC (permalink / raw)
To: Xichao Zhao
Cc: dave, jonathan.cameron, dave.jiang, vishal.l.verma, ira.weiny,
dan.j.williams, linux-cxl, linux-kernel
On Mon, Aug 11, 2025 at 08:25:19PM +0800, Xichao Zhao wrote:
> Use the string choice helper function str_plural() to simplify the code.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Thanks!
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> ---
> drivers/cxl/core/hdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index e9e1d555cec6..37176c0a781f 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -197,7 +197,7 @@ struct cxl_hdm *devm_cxl_setup_hdm(struct cxl_port *port,
> */
> if (should_emulate_decoders(info)) {
> dev_dbg(dev, "Fallback map %d range register%s\n", info->ranges,
> - info->ranges > 1 ? "s" : "");
> + str_plural(info->ranges));
> cxlhdm->decoder_count = info->ranges;
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/hdm: Use str_plural() to simplify the code
2025-08-11 12:25 [PATCH] cxl/hdm: Use str_plural() to simplify the code Xichao Zhao
2025-08-11 15:49 ` Dave Jiang
2025-08-12 0:14 ` Alison Schofield
@ 2025-08-13 0:01 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2025-08-13 0:01 UTC (permalink / raw)
To: Xichao Zhao, dave, jonathan.cameron, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel
On 8/11/25 5:25 AM, Xichao Zhao wrote:
> Use the string choice helper function str_plural() to simplify the code.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
applied to cxl/next
22fb4ad89885
> ---
> drivers/cxl/core/hdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index e9e1d555cec6..37176c0a781f 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -197,7 +197,7 @@ struct cxl_hdm *devm_cxl_setup_hdm(struct cxl_port *port,
> */
> if (should_emulate_decoders(info)) {
> dev_dbg(dev, "Fallback map %d range register%s\n", info->ranges,
> - info->ranges > 1 ? "s" : "");
> + str_plural(info->ranges));
> cxlhdm->decoder_count = info->ranges;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-13 0:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-11 12:25 [PATCH] cxl/hdm: Use str_plural() to simplify the code Xichao Zhao
2025-08-11 15:49 ` Dave Jiang
2025-08-12 0:14 ` Alison Schofield
2025-08-13 0:01 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).