Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-cxl@vger.kernel.org, jgg@nvidia.com, saeedm@nvidia.com,
	jonathan.cameron@huawei.com,
	Dan Williams <dan.j.williams@intel.com>,
	Li Ming <ming.li@zohomail.com>
Subject: Re: [PATCH v8 2/9] cxl: Move cxl feature command structs to user header
Date: Thu, 10 Apr 2025 08:10:04 -0700	[thread overview]
Message-ID: <7938f399-3e96-48a0-8329-5d938728e6dc@intel.com> (raw)
In-Reply-To: <20250410150315.GHZ_fds7lfQWfdQDrg@fat_crate.local>



On 4/10/25 8:03 AM, Borislav Petkov wrote:
> On Fri, Mar 07, 2025 at 01:55:32PM -0700, Dave Jiang wrote:
>> diff --git a/include/uapi/cxl/features.h b/include/uapi/cxl/features.h
>> new file mode 100644
>> index 000000000000..7f7ab4aefec2
>> --- /dev/null
>> +++ b/include/uapi/cxl/features.h
>> @@ -0,0 +1,169 @@
>> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>> +/*
>> + * Copyright (c) 2024,2025, Intel Corporation
>> + *
>> + * These are definitions for the mailbox command interface of CXL subsystem.
>> + */
>> +#ifndef _UAPI_CXL_FEATURES_H_
>> +#define _UAPI_CXL_FEATURES_H_
>> +
>> +#include <linux/types.h>
>> +#ifndef __KERNEL__
>> +#include <uuid/uuid.h>
>> +#else
>> +#include <linux/uuid.h>
>> +#endif
> 
> This doesn't help in allmodconfig builds:
> 
> In file included from ./usr/include/fwctl/cxl.h:12,
>                  from <command-line>:
> usr/include/cxl/features.h:11:10: fatal error: uuid/uuid.h: No such file or directory
>    11 | #include <uuid/uuid.h>
>       |          ^~~~~~~~~~~~~
> compilation terminated.
> make[4]: *** [usr/include/Makefile:85: usr/include/fwctl/cxl.hdrtest] Error 1
> make[3]: *** [scripts/Makefile.build:461: usr/include] Error 2
> make[2]: *** [scripts/Makefile.build:461: usr] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/home/amd/kernel/linux/Makefile:2006: .] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
> 

Thanks Boris. Jason has a fix queued for 6.15-rc.
https://lore.kernel.org/linux-cxl/20250407174910.GA1725933@nvidia.com/


Installing the uuid-devel package also helps with the allmodconfig issue for now.




  reply	other threads:[~2025-04-10 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 20:55 [PATCH v8 0/9] cxl: Add CXL feature commands support via fwctl Dave Jiang
2025-03-07 20:55 ` [PATCH v8 1/9] cxl: Add FWCTL support to CXL Dave Jiang
2025-03-07 20:55 ` [PATCH v8 2/9] cxl: Move cxl feature command structs to user header Dave Jiang
2025-03-12 18:19   ` Jonathan Cameron
2025-04-10 15:03   ` Borislav Petkov
2025-04-10 15:10     ` Dave Jiang [this message]
2025-04-10 15:12       ` Borislav Petkov
2025-03-07 20:55 ` [PATCH v8 3/9] cxl: Add support for fwctl RPC command to enable CXL feature commands Dave Jiang
2025-03-07 20:55 ` [PATCH v8 4/9] cxl: Add support to handle user feature commands for get feature Dave Jiang
2025-03-07 20:55 ` [PATCH v8 5/9] cxl: Add support to handle user feature commands for set feature Dave Jiang
2025-03-07 20:55 ` [PATCH v8 6/9] cxl/test: Add Get Feature support to cxl_test Dave Jiang
2025-03-07 20:55 ` [PATCH v8 7/9] cxl/test: Add Set " Dave Jiang
2025-03-07 20:55 ` [PATCH v8 8/9] fwctl/cxl: Add documentation to FWCTL CXL Dave Jiang
2025-03-07 20:55 ` [PATCH v8 9/9] cxl: Fixup kdoc issues for include/cxl/features.h Dave Jiang
2025-03-11  0:37   ` Li Ming
2025-03-20 23:23 ` [PATCH v8 0/9] cxl: Add CXL feature commands support via fwctl Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7938f399-3e96-48a0-8329-5d938728e6dc@intel.com \
    --to=dave.jiang@intel.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=jgg@nvidia.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox