public inbox for linux-cxl@vger.kernel.org
 help / color / mirror / Atom feed
From: "Cheatham, Benjamin" <benjamin.cheatham@amd.com>
To: Terry Bowman <terry.bowman@amd.com>, <dave@stgolabs.net>,
	<jonathan.cameron@huawei.com>, <dave.jiang@intel.com>,
	<alison.schofield@intel.com>, <dan.j.williams@intel.com>,
	<shiju.jose@huawei.com>, <ming.li@zohomail.com>,
	<Smita.KoralahalliChannabasappa@amd.com>, <rrichter@amd.com>,
	<dan.carpenter@linaro.org>, <PradeepVineshReddy.Kodamati@amd.com>,
	<lukas@wunner.de>, <sathyanarayanan.kuppuswamy@linux.intel.com>,
	<nvdimm@lists.linux.dev>, <alucerop@amd.com>,
	<ira.weiny@intel.com>
Cc: <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH 0/3] Enable CXL protocol testing
Date: Wed, 8 Apr 2026 16:39:41 -0500	[thread overview]
Message-ID: <7fe63454-9df7-47c9-ae7f-4db1fd1a3576@amd.com> (raw)
In-Reply-To: <20260408203231.962206-1-terry.bowman@amd.com>

On 4/8/2026 3:32 PM, Terry Bowman wrote:
> Current CXL error injection (EINJ) only supports Root Port protocol error
> injection but a method to test all CXL devices is needed. This series
> outlines methods to update both the kernel and the 'aer-inject' tool-without
> relying on EINJ-to enable CXL RAS protocol error handling across all CXL
> devices.
> 

This functionality should probably be added to the inject-protocol-error subcommand
instead of spread out across the directory as a bunch of scripts + patches. The command
is only set up for protocol error injection, but I don't think it would be *too* hard
to extend.

I think the first thing you have to do is expand the accepted device types to include ports and
memdevs instead of just dports. That should be simple enough, there are already helpers to find
both based on sbdf, name, etc. Then, you'd need to change the interface used to inject the error
based on device type (is it a root port? then use EINJ, otherwise use aer-inject). All that's
left at that point is to actually call the aer-inject command with the correct options (and
update the documentation/help messages).

I would be happy to help with any of the above if you agree with the direction, just let me
know!

Thanks,
Ben

  parent reply	other threads:[~2026-04-08 21:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 20:32 [ndctl PATCH 0/3] Enable CXL protocol testing Terry Bowman
2026-04-08 20:32 ` [ndctl PATCH 1/3] test/cxl: Enable CXL protocol error testing using aer-inject Terry Bowman
2026-04-08 21:39   ` Cheatham, Benjamin
2026-04-08 20:32 ` [ndctl PATCH 2/3] test/aer-inject: Add aer-inject correctable and uncorrectable interanl error support Terry Bowman
2026-04-08 20:32 ` [ndctl PATCH 3/3] test/cxl: Force RAS status in cxl_handle_cor_ras() and cxl_handle_ras() Terry Bowman
2026-04-08 21:39   ` Cheatham, Benjamin
2026-04-08 21:39 ` Cheatham, Benjamin [this message]
2026-04-09 17:05   ` [ndctl PATCH 0/3] Enable CXL protocol testing Dave Jiang
2026-04-21  4:05   ` Alison Schofield
2026-04-21 15:04     ` Bowman, Terry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fe63454-9df7-47c9-ae7f-4db1fd1a3576@amd.com \
    --to=benjamin.cheatham@amd.com \
    --cc=PradeepVineshReddy.Kodamati@amd.com \
    --cc=Smita.KoralahalliChannabasappa@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=alucerop@amd.com \
    --cc=dan.carpenter@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=ming.li@zohomail.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=rrichter@amd.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=shiju.jose@huawei.com \
    --cc=terry.bowman@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox