From: Dave Jiang <dave.jiang@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: dan.j.williams@intel.com, jonathan.cameron@huawei.com,
alison.schofield@intel.com, ira.weiny@intel.com,
vishal.l.verma@intel.com, seven.yi.lee@gmail.com,
a.manzanares@samsung.com, fan.ni@samsung.com,
anisa.su@samsung.com, linux-cxl@vger.kernel.org
Subject: Re: [PATCH 1/2] cxl/pmem: Export dirty shutdown count via sysfs
Date: Tue, 18 Feb 2025 11:58:02 -0700 [thread overview]
Message-ID: <7ff0d1a0-bd17-4089-afff-79ecb1ffc395@intel.com> (raw)
In-Reply-To: <20250211045016.d4erlklhps5rud2b@offworld>
On 2/10/25 9:50 PM, Davidlohr Bueso wrote:
> On Mon, 10 Feb 2025, Dave Jiang wrote:
>
>> On 2/4/25 9:08 PM, Davidlohr Bueso wrote:
>>> @@ -542,6 +542,7 @@ struct cxl_nvdimm {
>>> struct device dev;
>>> struct cxl_memdev *cxlmd;
>>> u8 dev_id[CXL_DEV_ID_LEN]; /* for nvdimm, string of 'serial' */
>>> + long dirty_shutdown;
>>
>> Maybe consider using u64 and call it 'dirty_shutdowns'?
>
> Imo signed type having -1 is more natural - are there any benefits in
> it being u64?
If it's a signed value and when it rolls over, it would show up as negative wouldn't it? Seems inconsistent with what the sysfs documentation says. Although that's a lot of dirty shutdowns for a system.... I suppose you can always force it to be unsigned when emit via sysfs.
>
> Thanks,
> Davidlohr
next prev parent reply other threads:[~2025-02-18 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 4:08 [PATCH 0/2] cxl: Dirty shutdown followups Davidlohr Bueso
2025-02-05 4:08 ` [PATCH 1/2] cxl/pmem: Export dirty shutdown count via sysfs Davidlohr Bueso
2025-02-07 10:46 ` Yee Li
2025-02-11 2:09 ` Dave Jiang
2025-02-11 4:50 ` Davidlohr Bueso
2025-02-18 18:58 ` Dave Jiang [this message]
2025-02-05 4:08 ` [PATCH 2/2] tools/testing/cxl: Set Shutdown State support Davidlohr Bueso
2025-02-11 2:16 ` Dave Jiang
2025-02-11 4:13 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff0d1a0-bd17-4089-afff-79ecb1ffc395@intel.com \
--to=dave.jiang@intel.com \
--cc=a.manzanares@samsung.com \
--cc=alison.schofield@intel.com \
--cc=anisa.su@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=seven.yi.lee@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox