From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Eric Blake" <eblake@redhat.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lukas Straub" <lukasstraub2@web.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
linux-cxl@vger.kernel.org, "Jason Wang" <jasowangio@gmail.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>, "Peter Xu" <peterx@redhat.com>
Subject: Re: [PATCH 5/6] qapi: convert intro sections with "TODO" markers
Date: Sat, 12 Sep 2026 08:58:14 +0200 [thread overview]
Message-ID: <877bkr3qih.fsf@pond.sub.org> (raw)
In-Reply-To: <20260911172200.227914-6-jsnow@redhat.com> (John Snow's message of "Fri, 11 Sep 2026 13:21:59 -0400")
John Snow <jsnow@redhat.com> writes:
> This patch converts intro sections that are immediately followed by a
> "TODO:" that was formerly used to demarcate the stub member insertion
> point.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> qapi/machine.json | 7 ++-----
> qapi/migration.json | 10 ++--------
> qapi/net.json | 9 +++------
> qapi/yank.json | 5 +----
> 4 files changed, 8 insertions(+), 23 deletions(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index 13875fc4642..108033b6d64 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1216,11 +1216,8 @@
>
> ##
> # @query-memory-size-summary:
> -#
> -# Return the amount of initially allocated and present hotpluggable
> -# (if enabled) memory in bytes.
> -#
> -# TODO: This line is a hack to separate the example from the body
> +# Return the amount of initially allocated and present
> +# hotpluggable (if enabled) memory in bytes.
> #
> # .. qmp-example::
> #
I see output change from
Command query-memory-size-summary (Since: 2.11)
Return the amount of initially allocated and present hotpluggable
(if enabled) memory in bytes.
Return:
"MemoryInfo"
Example::
-> { "execute": "query-memory-size-summary" }
<- { "return": { "base-memory": 4294967296, "plugged-memory": 0 } }
to
Command query-memory-size-summary (Since: 2.11)
Return the amount of initially allocated and present hotpluggable
(if enabled) memory in bytes.
Example::
-> { "execute": "query-memory-size-summary" }
<- { "return": { "base-memory": 4294967296, "plugged-memory": 0 } }
Return:
"MemoryInfo"
Similar for the other hunks. Surprising. What's going on?
[...]
next prev parent reply other threads:[~2026-09-12 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 17:21 [PATCH 0/6] qapi: convert remaining "simple" intro sections John Snow
2026-09-11 17:21 ` [PATCH 1/6] qapi: convert remaining simple intros for block-export.json John Snow
2026-09-12 7:34 ` Markus Armbruster
2026-09-11 17:21 ` [PATCH 2/6] qapi: convert remaining simple intros for cxl.json John Snow
2026-09-11 17:21 ` [PATCH 3/6] qapi: convert remaining simple intros for machine.json John Snow
2026-09-12 7:34 ` Markus Armbruster
2026-09-11 17:21 ` [PATCH 4/6] qapi: convert remaining simple intros for block-core.json John Snow
2026-09-12 7:35 ` Markus Armbruster
2026-09-11 17:21 ` [PATCH 5/6] qapi: convert intro sections with "TODO" markers John Snow
2026-09-12 6:58 ` Markus Armbruster [this message]
2026-09-11 17:22 ` [PATCH 6/6] qapi: convert intro sections followed by notes/examples John Snow
2026-09-12 7:36 ` [PATCH 0/6] qapi: convert remaining "simple" intro sections Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bkr3qih.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=jasowangio@gmail.com \
--cc=jic23@kernel.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@mailo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox