From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23BCD50097B for ; Mon, 12 Jan 2026 12:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768220291; cv=none; b=FLvPjEQ48MOX7aC7Fm6mjnu42quKebD21/gD7AvXDEoEZKlJD88WpkmSB8gX19PlBsC3qPuntr8+aYFYNFYq1q8po4ezdyoU7A+3ADrHx0fySR8ae8ANfojnj8ZQqhFdU/l6PK8WTDnjlSsyn2fpdkO4/XHrQNvUN2xAwzOb0QU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768220291; c=relaxed/simple; bh=4UFCGk0Fr/q1ZnEvGtDotVggP/JH4RoW05QbBEmDjv8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kCWMIwedPf4YShRUHO1j3u+VyPSgEj+6T33+88PRytWQnupXXr/zDCLPvirlEONsI9fggy4dBTznust492ilQI6EdRDGGEkRB4k48uFtybpMhy6QgLuSQy2hQpcUTyC+7lSPl752Yi4yD64CrOvi6CHSpUtdvWo1WZ28xIDWfmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E/VSIwnn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E/VSIwnn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768220289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=40Kf5ms2Kv38t+N1cc4C1QC+G5i0oZ2Ags3s47nY4H0=; b=E/VSIwnnS0PO+vtb6TLdDSBDsGKh+cNNhCTGMmBazPLKaVdjjpVnRJ5YAyIJiI6sRfMqYB NVzM4YQfxxnhZxXqrt5ur27fIwDzCoYO4EUH1CgqTNOg302l207y6A4KRLzKChmqqBHTlc FNRtVdGm50BA8UQE3IzypZuWrkUmAfM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-IcBe6D-OMB2CxNS2R71bUQ-1; Mon, 12 Jan 2026 07:18:06 -0500 X-MC-Unique: IcBe6D-OMB2CxNS2R71bUQ-1 X-Mimecast-MFC-AGG-ID: IcBe6D-OMB2CxNS2R71bUQ_1768220285 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D96991956050; Mon, 12 Jan 2026 12:18:04 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.32]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 810BC18001D5; Mon, 12 Jan 2026 12:18:04 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1CE9621E6742; Mon, 12 Jan 2026 13:18:02 +0100 (CET) From: Markus Armbruster To: Jonathan Cameron Cc: Michael Tsirkin , , , , , Ravi Shankar Subject: Re: [PATCH qemu v2 3/5] hw/cxl/events: Updates for rev3.2 general media event record In-Reply-To: <20260102151512.460766-4-Jonathan.Cameron@huawei.com> (Jonathan Cameron's message of "Fri, 2 Jan 2026 15:15:10 +0000") References: <20260102151512.460766-1-Jonathan.Cameron@huawei.com> <20260102151512.460766-4-Jonathan.Cameron@huawei.com> Date: Mon, 12 Jan 2026 13:18:02 +0100 Message-ID: <87h5srf2it.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Jonathan Cameron writes: > From: Shiju Jose > > CXL spec rev3.2 section 8.2.10.2.1.1 Table 8-57, general media event > table has updated with following new fields. > 1. Advanced Programmable Corrected Memory Error Threshold Event Flags > 2. Corrected Memory Error Count at Event > 3. Memory Event Sub-Type > 4. Support for component ID in the PLDM format. > > Add updates for the above spec changes in the CXL general media event > reporting and QMP command to inject general media event. > > Signed-off-by: Shiju Jose > Signed-off-by: Jonathan Cameron > --- > qapi/cxl.json | 15 ++++++++++++++- > include/hw/cxl/cxl_events.h | 7 +++++-- > hw/mem/cxl_type3.c | 29 +++++++++++++++++++++++++++++ > hw/mem/cxl_type3_stubs.c | 6 ++++++ > 4 files changed, 54 insertions(+), 3 deletions(-) > > diff --git a/qapi/cxl.json b/qapi/cxl.json > index b3c2ac9575..c5ecbe9646 100644 > --- a/qapi/cxl.json > +++ b/qapi/cxl.json > @@ -93,6 +93,16 @@ ## # @CXLGeneralMediaEvent: # # Event record for a General Media Event (CXL r3.0 8.2.9.2.1.1). # # @dpa: Device Physical Address (relative to @path device). Note # lower bits include some flags. See CXL r3.0 Table 8-43 General # Media Event Record, Physical Address. # [...] > # @component-id: Device specific component identifier for the event. > # May describe a field replaceable sub-component of the device. > # > +# @is-comp-id-pldm: This flag specifies whether the device-specific > +# component identifier format follows PLDM. > +# > +# @cme-ev-flags: Advanced programmable corrected memory error > +# threshold event flags. > +# > +# @cme-count: Corrected memory error count at event. > +# > +# @sub-type: Memory event sub-type. > +# You're not updating the reference to the CXL spec from 3.0 to 3.2. Intentional? > # Since: 8.1 > ## > { 'struct': 'CXLGeneralMediaEvent', > @@ -100,7 +110,10 @@ > 'data': { 'dpa': 'uint64', 'descriptor': 'uint8', > 'type': 'uint8', 'transaction-type': 'uint8', > '*channel': 'uint8', '*rank': 'uint8', > - '*device': 'uint32', '*component-id': 'str' } } > + '*device': 'uint32', '*component-id': 'str', > + '*is-comp-id-pldm':'bool', > + '*cme-ev-flags':'uint8', '*cme-count':'uint32', > + 'sub-type':'uint8' } } > > ## > # @cxl-inject-general-media-event: [...]