From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Amit Machhiwal" <amachhiw@linux.ibm.com>,
"Alexander Graf" <graf@amazon.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"zhenwei pi" <zhenwei.pi@linux.dev>,
"David Hildenbrand" <david@kernel.org>,
"Igor Mammedov" <imammedo@redhat.com>,
"Alberto Garcia" <berto@igalia.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Luc Michel" <luc@lmichel.fr>, "Zhao Liu" <zhao1.liu@intel.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Samuel Tardieu" <sam@rfc1149.net>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
"Song Gao" <17746591750@163.com>,
"Bibo Mao" <maobibo@loongson.cn>,
"Xianglai Li" <lixianglai@loongson.cn>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"FangSheng Huang" <FangSheng.Huang@amd.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Hao Wu" <wuhaotsh@google.com>,
"Jason Wang" <jasowangio@gmail.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>,
"Jesper Devantier" <foss@defmacro.it>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Aditya Gupta" <adityag@linux.ibm.com>,
"Glenn Miles" <milesg@linux.ibm.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Conor Dooley" <conor@kernel.org>,
"Sebastian Huber" <sebastian.huber@embedded-brains.de>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Weiwei Li" <liwei1518@gmail.com>,
"Daniel Henrique Barboza" <daniel.barboza@oss.qualcomm.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Chao Liu" <chao.liu@processmission.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Titus Rwantare" <titusr@google.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Zhang Chen" <zhangckid@gmail.com>,
"Li Zhijian" <lizhijian@fujitsu.com>,
"Peter Xu" <peterx@redhat.com>,
"Chinmay Rath" <rathc@linux.ibm.com>,
"Hendrik Brueckner" <brueckner@linux.ibm.com>,
kvm@vger.kernel.org, qemu-block@nongnu.org, qemu-arm@nongnu.org,
linux-cxl@vger.kernel.org, qemu-ppc@nongnu.org,
qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v5 35/62] qom: convert scalar properties to QAPI-aware registration
Date: Mon, 19 Oct 2026 09:41:59 +0200 [thread overview]
Message-ID: <87jyne2l2w.fsf@pond.sub.org> (raw)
In-Reply-To: <20260911-qom-qapi-v5-35-7732a55b7760@redhat.com> ("Marc-André Lureau"'s message of "Fri, 11 Sep 2026 20:35:09 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
[...]
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 872920b6482b..4e5d8d9f86e3 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -4258,7 +4258,7 @@ static void virt_machine_class_init(ObjectClass *oc, const void *data)
> "Set on/off to enable/disable high "
> "memory region for PCI MMIO");
>
> - object_class_property_add(oc, "highmem-mmio-size", "size",
> + object_class_property_add_qapi(oc, "highmem-mmio-size", &size_type_info,
> virt_get_highmem_mmio_size,
> virt_set_highmem_mmio_size,
> NULL, NULL);
> @@ -4266,7 +4266,7 @@ static void virt_machine_class_init(ObjectClass *oc, const void *data)
> "Set the high memory region size "
> "for PCI MMIO");
>
> - object_class_property_add(oc, "virtio-mmio-transports", "uint8",
> + object_class_property_add_qapi(oc, "virtio-mmio-transports", &uint8_type_info,
scripts/checkpatch.pl gripes
WARNING: line over 80 characters
Easy enough to avoid.
Many more below.
> virt_get_virtio_transports,
> virt_set_virtio_transports,
> NULL, NULL);
[...]
next prev parent reply other threads:[~2026-10-19 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260911-qom-qapi-v5-0-7732a55b7760@redhat.com>
2026-09-11 16:34 ` [PATCH v5 17/62] qom: convert struct properties to QAPI-aware registration Marc-André Lureau
2026-10-19 13:05 ` Markus Armbruster
2026-09-11 16:35 ` [PATCH v5 35/62] qom: convert scalar " Marc-André Lureau
2026-10-19 7:41 ` Markus Armbruster [this message]
2026-09-11 16:35 ` [PATCH v5 45/62] include: add QEMU_REPEAT helper macro Marc-André Lureau
2026-10-19 7:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyne2l2w.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=17746591750@163.com \
--cc=FangSheng.Huang@amd.com \
--cc=adityag@linux.ibm.com \
--cc=alistair.francis@wdc.com \
--cc=amachhiw@linux.ibm.com \
--cc=andrew@codeconstruct.com.au \
--cc=anisinha@redhat.com \
--cc=anthony@xenproject.org \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=berto@igalia.com \
--cc=borntraeger@linux.ibm.com \
--cc=brueckner@linux.ibm.com \
--cc=chao.liu@processmission.com \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=conor@kernel.org \
--cc=daniel.barboza@oss.qualcomm.com \
--cc=david@kernel.org \
--cc=den@openvz.org \
--cc=edgar.iglesias@gmail.com \
--cc=farman@linux.ibm.com \
--cc=foss@defmacro.it \
--cc=graf@amazon.com \
--cc=harshpb@linux.ibm.com \
--cc=hreitz@redhat.com \
--cc=iii@linux.ibm.com \
--cc=imammedo@redhat.com \
--cc=its@irrelevant.dk \
--cc=jamin_lin@aspeedtech.com \
--cc=jasowangio@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jic23@kernel.org \
--cc=jjherne@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=kane_chen@aspeedtech.com \
--cc=kbusch@kernel.org \
--cc=kfting@nuvoton.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=leetroy@gmail.com \
--cc=linux-cxl@vger.kernel.org \
--cc=liwei1518@gmail.com \
--cc=lixianglai@loongson.cn \
--cc=lizhijian@fujitsu.com \
--cc=luc@lmichel.fr \
--cc=maobibo@loongson.cn \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=milesg@linux.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rathc@linux.ibm.com \
--cc=richard.henderson@linaro.org \
--cc=sam@rfc1149.net \
--cc=sebastian.huber@embedded-brains.de \
--cc=sstabellini@kernel.org \
--cc=steven_lee@aspeedtech.com \
--cc=titusr@google.com \
--cc=wuhaotsh@google.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhangckid@gmail.com \
--cc=zhao1.liu@intel.com \
--cc=zhenwei.pi@linux.dev \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox