From: Markus Armbruster <armbru@redhat.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Jonathan Cameron via <qemu-devel@nongnu.org>,
Michael Tsirkin <mst@redhat.com>,
Ben Widawsky <bwidawsk@kernel.org>, <linux-cxl@vger.kernel.org>,
<linuxarm@huawei.com>, Ira Weiny <ira.weiny@intel.com>,
Alison Schofield <alison.schofield@intel.com>
Subject: Re: [RFC PATCH v2 1/3] hw/cxl: QMP based poison injection support
Date: Wed, 01 Feb 2023 17:10:09 +0100 [thread overview]
Message-ID: <87zg9xs6xq.fsf@pond.sub.org> (raw)
In-Reply-To: <20230201144512.00007b64@Huawei.com> (Jonathan Cameron's message of "Wed, 1 Feb 2023 14:45:12 +0000")
Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
> On Wed, 01 Feb 2023 13:14:06 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
[...]
>> Both commit message and doc comment are rather terse.
>>
>> The commit message should make the case for the feature: why do we want
>> it? This typically involves explaining the problem(s) it solves.
>>
>> The doc comment ideally explains intended use.
>
> OK. I'll expand on this. It'll be a bit of fuzzy text that
> boils down to we emulate so we can test the OS does the right thing
> when it gets poison related events. I can add some generic fluff on
> why a real device might implement this in the first place though
> I'm not sure that will even matter to anyone reading these docs.
Use your judgement :)
next prev parent reply other threads:[~2023-02-01 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 10:03 [RFC PATCH v2 0/3] hw/cxl: Poison get, inject, clear Jonathan Cameron
2023-02-01 10:03 ` [RFC PATCH v2 1/3] hw/cxl: QMP based poison injection support Jonathan Cameron
2023-02-01 12:14 ` Markus Armbruster
2023-02-01 14:45 ` Jonathan Cameron
2023-02-01 16:10 ` Markus Armbruster [this message]
2023-02-01 10:03 ` [RFC PATCH v2 2/3] hw/cxl: Add poison injection via the mailbox Jonathan Cameron
2023-02-01 10:03 ` [RFC PATCH v2 3/3] hw/cxl: Add clear poison mailbox command support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg9xs6xq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox