From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>,
"dave@stgolabs.net" <dave@stgolabs.net>,
"Schofield, Alison" <alison.schofield@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/mbox: Fix debug message print
Date: Mon, 31 Jul 2023 22:25:37 +0000 [thread overview]
Message-ID: <8a21c04e2f1ebecbef464794e4b0869b147a4525.camel@intel.com> (raw)
In-Reply-To: <64c831da6af64_52483294fb@dwillia2-xfh.jf.intel.com.notmuch>
On Mon, 2023-07-31 at 15:12 -0700, Dan Williams wrote:
> Ira Weiny wrote:
> > The handle value used to report an event being cleared by dev_dbg() is
> > incorrect due to a post increment of the payload handle index.
> >
> > Delay the increment of the index until after the print. Also add the
> > debugging for event processing which was useful in finding this bug.
> >
> > To: Davidlohr Bueso <dave@stgolabs.net>
> > To: Jonathan Cameron <jonathan.cameron@huawei.com>
> > To: Dave Jiang <dave.jiang@intel.com>
> > To: Alison Schofield <alison.schofield@intel.com>
> > To: Vishal Verma <vishal.l.verma@intel.com>
> > To: Dan Williams <dan.j.williams@intel.com>
>
> Is this some new process recommendation to use "To:", I would only
> expect Cc: for maintainers.
>
> > Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Jonathan gets listed twice because?
>
> > Cc: linux-cxl@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
>
> I assume this is because b4 takes its address from the patch itself?
>
> It just feels a bit too noisy.
Yes - but the better way to do this is to add the To: and Cc: lines in
b4 prep --edit-cover, even for a single patch branch. That way b4 uses
them to figure out where to send/cc, but other doesn't add them to
commit messages (or even the cover letter in case there is one).
next prev parent reply other threads:[~2023-07-31 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 20:52 [PATCH] cxl/mbox: Fix debug message print Ira Weiny
2023-07-31 21:53 ` Dave Jiang
2023-07-31 22:12 ` Dan Williams
2023-07-31 22:25 ` Verma, Vishal L [this message]
2023-08-01 18:45 ` Ira Weiny
2023-08-01 1:24 ` Alison Schofield
2023-08-01 18:48 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a21c04e2f1ebecbef464794e4b0869b147a4525.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox