Re: [RFC 1/5] cxl: Rename ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3

Davidlohr Bueso
2024-10-01T02:48:29Z

On Wed, 25 Sep 2024, Huang Ying wrote:

>According to the description of the "Window Restrictions" field of
>"CFMWS Structure" in the CXL spec v3.1 section 9.18.1.3: CXL Fixed
>Memory Window Structure (CFMWS), the bit 0 of "Window Restrictions" is
>formerly known as "CXL Type 2 Memory" and renamed to "Device
>Coherent", while the bit 1 is formerly known as "CXL Type 3 Memory"
>and renamed to "Host-only Coherent". Because type 3 memory can only
>be host-only coherent before, while it can be host-only coherent or
>device coherent with "Back-Invalidate" now.
>
>To avoid confusing about type 3 memory and host-only coherent in Linux
>kernel, we rename corresponding bit definition from
>ACPI_CEDT_CFMWS_RESTRICT_TYPE2/TYPE3 to
>ACPI_CEDT_CFMWS_RESTRICT_DEVCOH/HOSTONLYCOH. This makes the kernel
>code consistent with the spec too.
>
>Also rename the corresponding cxl_decoder flags
>CXL_DECODER_F_TYPE2/TYPE3 to CXL_DECODER_F_DEVCOH/HOSTONLYCOH.
>
>No functionality change is expected, because we just rename the flags
>constant definition.
>
>Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>Suggested-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>Cc: Dan Williams <dan.j.williams@intel.com>
>Cc: Davidlohr Bueso <dave@stgolabs.net>
>Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
>Cc: Dave Jiang <dave.jiang@intel.com>
>Cc: Alison Schofield <alison.schofield@intel.com>
>Cc: Vishal Verma <vishal.l.verma@intel.com>
>Cc: Ira Weiny <ira.weiny@intel.com>
>Cc: Alejandro Lucero <alucerop@amd.com>

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>