Re: [RFC 4/5] cxl: Set type of region to that of the first endpoint

Huang, Ying
2024-10-02T00:44:25Z

Gregory Price <gourry@gourry.net> writes:

> On Wed, Sep 25, 2024 at 10:46:46AM +0800, Huang Ying wrote:
>> The type of region is hard-coded as type 3 expander now, because this
>> is the only supported device type. As a preparation to support type 2
>> accelerators, we set the type of region to that of the first endpoint.
>> Then, we will check whether the type of region is same as the type of
>> other endpoints of the region. Because what we really need is to make
>> sure the type of all endpoints of a region is same.
>>
>> The target type of endpoint devices comes from expander/accelerator
>> device drivers via struct cxl_dev_state.
>>
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: Davidlohr Bueso <dave@stgolabs.net>
>> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
>> Cc: Dave Jiang <dave.jiang@intel.com>
>> Cc: Alison Schofield <alison.schofield@intel.com>
>> Cc: Vishal Verma <vishal.l.verma@intel.com>
>> Cc: Ira Weiny <ira.weiny@intel.com>
>> Cc: Alejandro Lucero <alucerop@amd.com>
>> ---
>> drivers/cxl/acpi.c | 1 -
>> drivers/cxl/core/hdm.c | 28 +++++++++++++---------------
>> drivers/cxl/core/port.c | 2 ++
>> drivers/cxl/core/region.c | 13 +++++++------
>> drivers/cxl/cxl.h | 1 +
>> 5 files changed, 23 insertions(+), 22 deletions(-)
>>
>
> Reviewed-by: Gregory Price <gourry@gourry.net>

Thanks!

>> static ssize_t create_pmem_region_store(struct device *dev,
>> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
>> index 99398c868d82..2a2d2c483654 100644
>> --- a/drivers/cxl/cxl.h
>> +++ b/drivers/cxl/cxl.h
>> @@ -324,6 +324,7 @@ resource_size_t cxl_rcd_component_reg_phys(struct device *dev,
>> #define CXL_DECODER_F_MASK GENMASK(5, 0)
>>
>> enum cxl_decoder_type {
>> + CXL_DECODER_INVALID,
>
> nit - should this be an explicit value?

Sure. Will fix this in the future version!

>> CXL_DECODER_ACCEL = 2,
>> CXL_DECODER_EXPANDER = 3,
>> };
>> --
>> 2.39.2
>>

--
Best Regards,
Huang, Ying