From: "Daisuke Kobayashi (Fujitsu)" <kobayashi.da-06@fujitsu.com>
To: "'Martin Mareš'" <mj@ucw.cz>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"Yasunori Gotou (Fujitsu)" <y-goto@fujitsu.com>,
"'mj@ucw.cz'" <mj@ucw.cz>
Subject: RE: [RFC PATCH 0/3] lspci: Display cxl1.1 device link status
Date: Thu, 18 Jan 2024 05:07:40 +0000 [thread overview]
Message-ID: <TYCPR01MB117646BFAEC01B301BE485D4FBA712@TYCPR01MB11764.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <mj+md-20240117.120837.23579.nikam@ucw.cz>
> -----Original Message-----
> From: Martin Mareš <mj@ucw.cz>
> Sent: Wednesday, January 17, 2024 9:11 PM
> To: Kobayashi, Daisuke/小林 大介 <kobayashi.da-06@fujitsu.com>
> Cc: linux-pci@vger.kernel.org; linux-cxl@vger.kernel.org; Gotou, Yasunori/五島
> 康文 <y-goto@fujitsu.com>
> Subject: Re: [RFC PATCH 0/3] lspci: Display cxl1.1 device link status
>
> Hello!
>
> Sorry for the late reply, but these days I don't read linux-pci regularly. Please Cc
> me on all patches for the pciutils.
>
I see. I'll include you in CC.
> Anyway...
>
> I don't think this is the right approach. You poke things you shouldn't in user
> space, you also make some bold assumptions on endianity of the machine (you
> are using native C structs for data provided by the hardware).
>
> This belongs to the kernel.
Thank you, Martin. I just want to say you made a good point.
I totally missed that, so thanks for pointing it out.
>
> Have a nice fortnight
> --
> Martin `MJ' Mareš <mj@ucw.cz>
> http://mj.ucw.cz/
> United Computer Wizards, Prague, Czech Republic, Europe, Earth, Universe
prev parent reply other threads:[~2024-01-18 5:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 5:07 [RFC PATCH 0/3] lspci: Display cxl1.1 device link status KobayashiDaisuke
2023-12-20 5:07 ` [RFC PATCH 1/3] Add function to display " KobayashiDaisuke
2023-12-20 5:07 ` [RFC PATCH 2/3] Implement a function to get cxl1.1 device uid KobayashiDaisuke
2023-12-20 5:07 ` [RFC PATCH 3/3] Implement a function to get a RCRB Base address KobayashiDaisuke
2024-01-09 15:57 ` [RFC PATCH 0/3] lspci: Display cxl1.1 device link status Jonathan Cameron
2024-01-11 1:11 ` Dan Williams
2024-01-12 11:24 ` Jonathan Cameron
2024-01-15 9:09 ` Daisuke Kobayashi (Fujitsu)
2024-01-16 21:29 ` Dan Williams
2024-01-17 9:23 ` Daisuke Kobayashi (Fujitsu)
2024-01-17 12:10 ` Martin Mareš
2024-01-18 5:07 ` Daisuke Kobayashi (Fujitsu) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB117646BFAEC01B301BE485D4FBA712@TYCPR01MB11764.jpnprd01.prod.outlook.com \
--to=kobayashi.da-06@fujitsu.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=y-goto@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox