From: Junhyeok Im <junhyeok.im@samsung.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: linux-cxl@vger.kernel.org, dan.j.williams@intel.com,
vishal.l.verma@intel.com, bwidawsk@kernel.org
Subject: Re: [ndctl 2/3] cxl: add inject-poison command to cxl tool
Date: Tue, 28 Feb 2023 18:45:16 +0900 [thread overview]
Message-ID: <Y/3NLEdkuNXoFLb2@dell-ArcherCity> (raw)
In-Reply-To: <Y/wivgTuKuxvB2jt@aschofie-mobl2>
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
On Sun, Feb 26, 2023 at 07:25:50PM -0800, Alison Schofield wrote:
> On Mon, Feb 20, 2023 at 01:57:08PM +0900, Junhyeok Im wrote:
> > Add new command to cli tool, to inject poison into dpa(-a) on the
> > memory device.
> >
> > DPA written in sysfs attribute(inject_poison) is converted by
> > kstrtou64 with 0 base by 'inject_poison_store' of CXL driver, so if
> > it begins with 0x the number will be parsed as a hexadecimal
> > (case insensitive), if it otherwise begins with 0, it will be parsed
> > as an octal number. Otherwise it will be parsed as a decimal.
> >
> > Since the validity verification of the dpa would be done in
> > 'cxl_validate_poison_dpa' of CXL driver, no additional logic
> > is added.
> >
> > Also since it is expected no use case of injecting poison into the
> > same address for multiple devices, this command targets only one
> > memdev, like write-labels command.
> >
> > usage: cxl inject-poison <memdev> -a <dpa> [<options>]
> >
> > -v, --verbose turn on debug
> > -S, --serial use serial numbers to id memdevs
> > -a, --address <dpa> DPA to inject poison
> >
>
> Upon successful completion of the command, display the --media-errors
> list for that device.
>
> <snip>
>
So, your comment is that the media-errors list (like $ cxl list --media-erros)
should be printed after command completion.
I agree in terms of the completeness of the command operation.
Thank you for your good opinion. I'll make up for it.
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-02-28 9:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230220045604epcas2p3bc0b1fb688c48ec0b8ae2512adba3513@epcas2p3.samsung.com>
2023-02-20 4:57 ` [ndctl 0/3] Support for inject poison Junhyeok Im
2023-02-20 4:57 ` [ndctl 1/3] libcxl: add memdev inject poison support Junhyeok Im
2023-02-27 2:43 ` Alison Schofield
2023-02-20 4:57 ` [ndctl 2/3] cxl: add inject-poison command to cxl tool Junhyeok Im
2023-02-27 3:21 ` Alison Schofield
2023-02-28 9:43 ` Junhyeok Im
2023-03-01 19:01 ` Verma, Vishal L
2023-02-27 3:25 ` Alison Schofield
2023-02-28 9:45 ` Junhyeok Im [this message]
2023-02-20 4:57 ` [ndctl 3/3] Documentation: add man page documentation for inject-poison Junhyeok Im
2023-02-27 2:38 ` [ndctl 0/3] Support for inject poison Alison Schofield
2023-02-28 9:31 ` Junhyeok Im
2023-05-08 18:39 ` Verma, Vishal L
2023-05-09 9:19 ` Junhyeok Im
[not found] <CGME20230220013613epcas2p23cee8c0fe839f12ca125e97c6f66d815@epcas2p2.samsung.com>
2023-02-20 1:37 ` [ndctl 1/3] libcxl: add memdev inject poison support junhyeok.im
2023-02-20 1:37 ` [ndctl 2/3] cxl: add inject-poison command to cxl tool junhyeok.im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/3NLEdkuNXoFLb2@dell-ArcherCity \
--to=junhyeok.im@samsung.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox