From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: linux-cxl@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linuxarm@huawei.com
Subject: Re: [PATCH] cxl/mbox: Drop extra struct resource cast
Date: Wed, 1 Mar 2023 17:46:42 +0200 [thread overview]
Message-ID: <Y/9zYlHETHByXRUz@smile.fi.intel.com> (raw)
In-Reply-To: <Y/9zKXOKI1h2nvEI@smile.fi.intel.com>
On Wed, Mar 01, 2023 at 05:45:45PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 28, 2023 at 03:21:12PM +0000, Jonathan Cameron wrote:
> > DEFINE_RES_MEM() is a wrapper around the DEFINE_RES_NAMED()
> > macro which already has the (struct resource) cast.
>
> It's not a cast. As commit message that brought it says: "Converting it to be
> a compound literal..."
...
> > - cxlds->dpa_res =
> > - (struct resource)DEFINE_RES_MEM(0, cxlds->total_bytes);
FWIW, here it's also not a cast.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-03-01 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 15:21 [PATCH] cxl/mbox: Drop extra struct resource cast Jonathan Cameron
2023-02-28 15:44 ` Dave Jiang
2023-03-01 15:45 ` Andy Shevchenko
2023-03-01 15:46 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9zYlHETHByXRUz@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox