From: Alison Schofield <alison.schofield@intel.com>
To: Jonathan Zhang <jonzhang@meta.com>
Cc: linux-cxl@vger.kernel.org, vishal.l.verma@intel.com,
wzhang@meta.com, Jonathan Zhang <jonzhang@fb.com>
Subject: Re: [ndctl PATCH V2 1/2] libcxl: add accessors for Get Alert Configuration CCI output
Date: Mon, 31 Oct 2022 11:57:47 -0700 [thread overview]
Message-ID: <Y2Aaq6dFXlr92W/6@aschofie-mobl2> (raw)
In-Reply-To: <20221025204320.290354-2-jonzhang@meta.com>
On Tue, Oct 25, 2022 at 01:43:19PM -0700, Jonathan Zhang wrote:
> From: Jonathan Zhang <jonzhang@fb.com>
>
> CXL 3.0 spec section 8.2.9.8.3.2 "Get Alert Configuration
> (Opcode 4201h) defines the get-alert-config command to
> retrieve the devices's critical alert and programmable
> warning configurations.
>
> Add the methods to issue the command and get the fields
> defined.
>
> Signed-off-by: Jonathan Zhang <jonzhang@meta.com>
Consistency in typos are trickier to detect ;)
> +CXL_EXPORT int
> +cxl_cmd_alert_config_life_used_prog_warn_threshold_writable(struct cxl_cmd *cmd)
> +{
> + cmd_alert_get_prog_alerts_field(
> + cmd,
> + CXL_CMD_ALERT_CONFIG_PROG_ALERTS_LIEF_USED_PROG_WARN_THRESHOLD_MASK);
> +}
> +
--snip--
> +#define CXL_CMD_ALERT_CONFIG_PROG_ALERTS_LIEF_USED_PROG_WARN_THRESHOLD_MASK \
> + BIT(0)
--snip--
>
next prev parent reply other threads:[~2022-10-31 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 20:43 [ndctl PATCH V2 0/2] add support for CCI Get Alert Configuration Jonathan Zhang
2022-10-25 20:43 ` [ndctl PATCH V2 1/2] libcxl: add accessors for Get Alert Configuration CCI output Jonathan Zhang
2022-10-31 18:57 ` Alison Schofield [this message]
2022-10-31 23:46 ` Jonathan Zhang (Infra)
2022-11-01 0:57 ` Alison Schofield
2022-11-01 1:24 ` Jonathan Zhang (Infra)
2022-10-25 20:43 ` [ndctl PATCH V2 2/2] cxl: display alert configuration fields Jonathan Zhang
2022-10-31 18:50 ` Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2Aaq6dFXlr92W/6@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=jonzhang@fb.com \
--cc=jonzhang@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=wzhang@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox