Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Ben Widawsky <bwidawsk@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] tools/testing/cxl: Mock the max err records field of Identify cmd
Date: Thu, 17 Nov 2022 16:25:40 -0800	[thread overview]
Message-ID: <Y3bRBGTAKutMgfo0@aschofie-mobl2> (raw)
In-Reply-To: <20221116125145.000009c2@Huawei.com>

On Wed, Nov 16, 2022 at 12:51:45PM +0000, Jonathan Cameron wrote:
> On Thu, 10 Nov 2022 19:12:43 -0800
> alison.schofield@intel.com wrote:
> 
> > From: Alison Schofield <alison.schofield@intel.com>
> > 
> > The CXL mbox command Identify reports the maximum media error
> > records that a device will report. Mock it here for testing
> > the GET POISON LIST mbox command.
> > 
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> > ---
> >  tools/testing/cxl/test/mem.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> > index aa2df3a15051..f0704d090073 100644
> > --- a/tools/testing/cxl/test/mem.c
> > +++ b/tools/testing/cxl/test/mem.c
> > @@ -111,6 +111,10 @@ static int mock_id(struct cxl_dev_state *cxlds, struct cxl_mbox_cmd *cmd)
> >  			cpu_to_le64(DEV_SIZE / CXL_CAPACITY_MULTIPLIER),
> >  	};
> >  
> > +	__le32 val = cpu_to_le32(SZ_64);
> > +
> > +	memcpy(id.poison_list_max_mer, &val, 3);
> As in other direction, can we do this with a buffer of the right size if
> we can't do a put_unaligned_le24() directly.
> 
Yes. Got it, thanks!

> > +
> >  	if (cmd->size_out < sizeof(id))
> >  		return -EINVAL;
> >  
> 

  reply	other threads:[~2022-11-18  0:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11  3:12 [PATCH v3 0/6] CXL Poison List Retrieval & Tracing alison.schofield
2022-11-11  3:12 ` [PATCH v3 1/6] trace, cxl: Introduce a TRACE_EVENT for CXL poison records alison.schofield
2022-11-16 12:19   ` Jonathan Cameron
2022-12-04 22:42   ` Dan Williams
2022-11-11  3:12 ` [PATCH v3 2/6] cxl/mbox: Add GET_POISON_LIST mailbox command alison.schofield
2022-11-16 12:41   ` Jonathan Cameron
2022-11-17 23:55     ` Alison Schofield
2022-12-07  2:41   ` Dan Williams
2022-12-07 16:10     ` Alison Schofield
2022-12-07 21:39       ` Dan Williams
2022-12-08  3:47         ` Alison Schofield
2022-11-11  3:12 ` [PATCH v3 3/6] cxl/memdev: Add trigger_poison_list sysfs attribute alison.schofield
2022-11-16 12:48   ` Jonathan Cameron
2022-11-18  0:15     ` Alison Schofield
2022-11-11  3:12 ` [PATCH v3 4/6] cxl/region: " alison.schofield
2022-11-16 12:50   ` Jonathan Cameron
2022-11-18  0:24     ` Alison Schofield
2022-11-11  3:12 ` [PATCH v3 5/6] tools/testing/cxl: Mock the max err records field of Identify cmd alison.schofield
2022-11-16 12:51   ` Jonathan Cameron
2022-11-18  0:25     ` Alison Schofield [this message]
2022-11-11  3:12 ` [PATCH v3 6/6] tools/testing/cxl: Mock the Get Poison List mbox command alison.schofield
2022-11-16 12:52   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3bRBGTAKutMgfo0@aschofie-mobl2 \
    --to=alison.schofield@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox