Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ben Widawsky <bwidawsk@kernel.org>,
	Dave Jiang <dave.jiang@intel.com>,
	linux-cxl@vger.kernel.org
Subject: Re: [PATCH v6 2/3] cxl/acpi: Support CXL XOR Interleave Math (CXIMS)
Date: Thu, 17 Nov 2022 16:32:53 -0800	[thread overview]
Message-ID: <Y3bStbK7whfEPXah@aschofie-mobl2> (raw)
In-Reply-To: <20221114185729.nxahgs66ybe2x5mr@offworld>

On Mon, Nov 14, 2022 at 10:57:29AM -0800, Davidlohr Bueso wrote:
> On Mon, 14 Nov 2022, Alison Schofield wrote:
> 
> > The reasoning behind removing the check, versus expanding it, is that the
> > check shouldn't have been there in the first place. The ACPI driver is
> > responsible for parsing the CFMWS's but it is the responsibility of the
> > region driver to decide which CFMWS's it can use.
> > 
> > If you believe that premise, then we let all interleave arithmetics
> > 'get through' to the region driver.
> 
> The way I see it, acpi should be setting the callback because it is a _direct_
> consequence of parsing the cfmws, and that's really the same logic as we have
> now, in that it sets it when allocating the rp decoder. And that doesn't take
> away from the region driver responsibility of choosing the actual host bridge.

With a little help from my friends ;) I'm hopeful the next version
meets your expectation by setting the calc_hb only once when allocating
that root port decoder.

> 
> Thanks,
> Davidlohr

  reply	other threads:[~2022-11-18  0:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12  4:41 [PATCH v6 0/3] CXL XOR Interleave Arithmetic alison.schofield
2022-11-12  4:41 ` [PATCH v6 1/3] ACPICA commit 2d8dc0383d3c908389053afbdc329bbd52f009ce alison.schofield
2022-11-12  4:41 ` [PATCH v6 2/3] cxl/acpi: Support CXL XOR Interleave Math (CXIMS) alison.schofield
2022-11-12  6:28   ` Davidlohr Bueso
2022-11-14 17:39     ` Alison Schofield
2022-11-14 18:57       ` Davidlohr Bueso
2022-11-18  0:32         ` Alison Schofield [this message]
2022-11-12  4:41 ` [PATCH v6 3/3] tools/testing/cxl: Add XOR Math support to cxl_test alison.schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3bStbK7whfEPXah@aschofie-mobl2 \
    --to=alison.schofield@intel.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox