From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D86C4338F for ; Fri, 13 Aug 2021 10:15:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0098460F57 for ; Fri, 13 Aug 2021 10:15:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239277AbhHMKPd (ORCPT ); Fri, 13 Aug 2021 06:15:33 -0400 Received: from mga01.intel.com ([192.55.52.88]:52439 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239016AbhHMKPd (ORCPT ); Fri, 13 Aug 2021 06:15:33 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="237579449" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="237579449" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 03:15:06 -0700 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="591068974" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 03:15:04 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mEUDK-0091rD-Cu; Fri, 13 Aug 2021 13:14:58 +0300 Date: Fri, 13 Aug 2021 13:14:58 +0300 From: Andy Shevchenko To: Dan Williams , Christoph Hellwig Cc: linux-cxl@vger.kernel.org, Linux NVDIMM , Jonathan Cameron , Ben Widawsky , Vishal L Verma , "Schofield, Alison" , "Weiny, Ira" Subject: Re: [PATCH 10/23] libnvdimm/labels: Add uuid helpers Message-ID: References: <162854806653.1980150.3354618413963083778.stgit@dwillia2-desk3.amr.corp.intel.com> <162854812073.1980150.8157116233571368158.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, Aug 12, 2021 at 03:34:59PM -0700, Dan Williams wrote: > On Wed, Aug 11, 2021 at 12:18 PM Andy Shevchenko > wrote: > > > > On Wed, Aug 11, 2021 at 10:11:56AM -0700, Dan Williams wrote: > > > On Wed, Aug 11, 2021 at 9:59 AM Andy Shevchenko > > > wrote: > > > > On Wed, Aug 11, 2021 at 11:05:55AM +0300, Andy Shevchenko wrote: > > > > > On Mon, Aug 09, 2021 at 03:28:40PM -0700, Dan Williams wrote: > > > > > > In preparation for CXL labels that move the uuid to a different offset > > > > > > in the label, add nsl_{ref,get,validate}_uuid(). These helpers use the > > > > > > proper uuid_t type. That type definition predated the libnvdimm > > > > > > subsystem, so now is as a good a time as any to convert all the uuid > > > > > > handling in the subsystem to uuid_t to match the helpers. > > > > > > > > > > > > As for the whitespace changes, all new code is clang-format compliant. > > > > > > > > > > Thanks, looks good to me! > > > > > Reviewed-by: Andy Shevchenko > > > > > > > > Sorry, I'm in doubt this Rb stays. See below. > > Andy, does this incremental diff restore your reviewed-by? The awkward > piece of this for me is that it introduces a handful of unnecessary > memory copies. See some of the new nsl_get_uuid() additions and the > extra copy in nsl_uuid_equal() It does, thanks! As for the deeper discussion I think you need to talk to Christoph. It was his idea to move uuid_t from UAPI to internal kernel type. And I think it made and still makes sense to be that way. But if we have already users of uuid_t like you are doing here (without this patch) then it will be fine I guess. Not my area to advise or decide. -- With Best Regards, Andy Shevchenko